From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder
Date: Wed, 20 Feb 2019 09:35:02 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB977258012413B796@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20190219145308.65668-5-bruce.richardson@intel.com>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, February 19, 2019 2:53 PM
> To: dev@dpdk.org; thomas@monjalon.net
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: [PATCH v2 4/5] test/bpf: move to examples folder
>
> The bpf folder didn't actual contain a test application, but instead
> basic examples of BPF code for use with testpmd.
Might be the better to create app/test-pmf/bpf directory
and move them into it.
Konstantin
> Therefore we can
> move it to the `examples` folder. Being different, it also needs
> a README with it, explaining what it is and how to use it. References
> to the code from the testpmd docs are suitably updated.
>
> CC: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> MAINTAINERS | 2 +-
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++----
> examples/bpf/README | 8 ++++++++
> {test => examples}/bpf/dummy.c | 0
> {test => examples}/bpf/mbuf.h | 0
> examples/bpf/meson.build | 6 ++++++
> {test => examples}/bpf/t1.c | 0
> {test => examples}/bpf/t2.c | 0
> {test => examples}/bpf/t3.c | 0
> 9 files changed, 19 insertions(+), 5 deletions(-)
> create mode 100644 examples/bpf/README
> rename {test => examples}/bpf/dummy.c (100%)
> rename {test => examples}/bpf/mbuf.h (100%)
> create mode 100644 examples/bpf/meson.build
> rename {test => examples}/bpf/t1.c (100%)
> rename {test => examples}/bpf/t2.c (100%)
> rename {test => examples}/bpf/t3.c (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c4619174a..6d1d0aea7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1230,7 +1230,7 @@ F: doc/guides/howto/telemetry.rst
> BPF - EXPERIMENTAL
> M: Konstantin Ananyev <konstantin.ananyev@intel.com>
> F: lib/librte_bpf/
> -F: test/bpf/
> +F: examples/bpf/
> F: test/test/test_bpf.c
> F: doc/guides/prog_guide/bpf_lib.rst
>
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 029148041..b079c60d9 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4503,20 +4503,20 @@ For example:
>
> .. code-block:: console
>
> - cd test/bpf
> + cd examples/bpf
> clang -O2 -target bpf -c t1.c
>
> Then to load (and JIT compile) t1.o at RX queue 0, port 1::
>
> .. code-block:: console
>
> - testpmd> bpf-load rx 1 0 J ./dpdk.org/test/bpf/t1.o
> + testpmd> bpf-load rx 1 0 J ./dpdk.org/examples/bpf/t1.o
>
> To load (not JITed) t1.o at TX queue 0, port 0::
>
> .. code-block:: console
>
> - testpmd> bpf-load tx 0 0 - ./dpdk.org/test/bpf/t1.o
> + testpmd> bpf-load tx 0 0 - ./dpdk.org/examples/bpf/t1.o
>
> bpf-unload
> ~~~~~~~~~~
> @@ -4529,4 +4529,4 @@ For example to unload BPF filter from TX queue 0, port 0:
>
> .. code-block:: console
>
> - testpmd> bpf-load tx 0 0 - ./dpdk.org/test/bpf/t1.o
> + testpmd> bpf-unload tx 0 0
> diff --git a/examples/bpf/README b/examples/bpf/README
> new file mode 100644
> index 000000000..d714180a5
> --- /dev/null
> +++ b/examples/bpf/README
> @@ -0,0 +1,8 @@
> +This folder contains example BPF programs for use with the DPDK bpf
> +library. To get details of each program and how to compile it, see
> +the header on the '.c' file itself.
> +
> +Once compiled, these example programs can be loaded into `testpmd`
> +for execution on a packet stream. See `bpf-load` and `bpf-unload`
> +commands documented in the `Testpmd Application User Guide` for
> +details on how to do so.
> diff --git a/test/bpf/dummy.c b/examples/bpf/dummy.c
> similarity index 100%
> rename from test/bpf/dummy.c
> rename to examples/bpf/dummy.c
> diff --git a/test/bpf/mbuf.h b/examples/bpf/mbuf.h
> similarity index 100%
> rename from test/bpf/mbuf.h
> rename to examples/bpf/mbuf.h
> diff --git a/examples/bpf/meson.build b/examples/bpf/meson.build
> new file mode 100644
> index 000000000..0a817aaea
> --- /dev/null
> +++ b/examples/bpf/meson.build
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +
> +# This contains BPF example code for use in testing BPF with testpmd,
> +# therefore it should not be built as part of a meson build.
> +build=false
> diff --git a/test/bpf/t1.c b/examples/bpf/t1.c
> similarity index 100%
> rename from test/bpf/t1.c
> rename to examples/bpf/t1.c
> diff --git a/test/bpf/t2.c b/examples/bpf/t2.c
> similarity index 100%
> rename from test/bpf/t2.c
> rename to examples/bpf/t2.c
> diff --git a/test/bpf/t3.c b/examples/bpf/t3.c
> similarity index 100%
> rename from test/bpf/t3.c
> rename to examples/bpf/t3.c
> --
> 2.20.1
next prev parent reply other threads:[~2019-02-20 9:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:26 [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 2/4] test/test-acl: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 3/4] test/test-pipeline: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder Bruce Richardson
2019-01-25 20:30 ` [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-29 11:40 ` Thomas Monjalon
2019-01-29 11:52 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 0/5] " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 9:14 ` Thomas Monjalon
2019-02-26 10:00 ` Bruce Richardson
2019-02-26 11:24 ` Bruce Richardson
2019-02-26 12:20 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 2/5] test/test-acl: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 3/5] test/test-pipeline: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-20 9:35 ` Ananyev, Konstantin [this message]
2019-02-20 9:39 ` Bruce Richardson
2019-02-20 9:42 ` Ananyev, Konstantin
2019-02-20 10:35 ` Thomas Monjalon
2019-02-25 16:22 ` Ananyev, Konstantin
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 5/5] test/test: move to app folder Bruce Richardson
2019-02-20 11:47 ` [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir Ferruh Yigit
2019-02-25 15:34 ` Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 2/5] test/test-acl: " Bruce Richardson
2019-02-26 12:27 ` Ananyev, Konstantin
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 3/5] test/test-pipeline: " Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 5/5] test/test: move to app folder Bruce Richardson
2019-02-26 14:40 ` [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB977258012413B796@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).