From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed
Date: Thu, 10 Dec 2015 14:50:31 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1449755601-25670-1-git-send-email-bernard.iremonger@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger
> Sent: Thursday, December 10, 2015 1:53 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] examples/vhost: reduce number of hugepages needed
>
> Change MAX_QUEUES from 512 to 128 to reduce the number of hugepages
> required by the vhost-switch program.
>
> Changes in v2:
> remove comment added before #define MAX_QUEUES in v1 patch.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Wasn't it increased a while ago, because someone complained that
128 queues might not be enough on FVL?
>From git log I can see that it was first increased from 128 to 256,
then from 256 to 512.
The reason mentioned - HW that has bigger number of queues.
Isn't it not the case anymore?
If yes, why?
BTW, shouldn't it be then at least:
+#ifndef MAX_QUEUES
+#define MAX_QUEUES 128
+#endif
So people can just do -D MAX_QUEUES=X at build time if they like(need) to.
Konstantin
> ---
> examples/vhost/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index b30f1bd..5ce5926 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -1,7 +1,7 @@
> /*-
> * BSD LICENSE
> *
> - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> * All rights reserved.
> *
> * Redistribution and use in source and binary forms, with or without
> @@ -53,7 +53,7 @@
>
> #include "main.h"
>
> -#define MAX_QUEUES 512
> +#define MAX_QUEUES 128
>
> /* the maximum number of external ports supported */
> #define MAX_SUP_PORTS 1
> --
> 2.6.3
next prev parent reply other threads:[~2015-12-10 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:19 [dpdk-dev] [PATCH] " Bernard Iremonger
2015-12-10 12:59 ` Yuanhan Liu
2015-12-10 13:26 ` Iremonger, Bernard
2015-12-10 13:34 ` Yuanhan Liu
2015-12-10 13:53 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2015-12-10 14:50 ` Ananyev, Konstantin [this message]
2015-12-10 15:43 ` Iremonger, Bernard
2015-12-11 9:05 ` Panu Matilainen
2015-12-10 15:49 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2015-12-10 16:32 ` Ananyev, Konstantin
2015-12-10 21:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836AD25A2@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).