DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Jia He <hejianet@gmail.com>,
	"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"jianbo.liu@arm.com" <jianbo.liu@arm.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"jie2.liu@hxt-semitech.com" <jie2.liu@hxt-semitech.com>,
	"bing.zhao@hxt-semitech.com" <bing.zhao@hxt-semitech.com>,
	"jia.he@hxt-semitech.com" <jia.he@hxt-semitech.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue
Date: Wed, 8 Nov 2017 09:49:11 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772585FABAC40@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1510121832-16439-2-git-send-email-hejianet@gmail.com>


> +
> +#define UNUSED_PARAMETER(x) ((void)(x))
> +static __rte_always_inline void
> +update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,
> +		uint32_t single, uint32_t enqueue)
> +{
> +	UNUSED_PARAMETER(enqueue);

As a nit you can use __rte_unused parameter attribute or
RTE_SET_USED() macro here.

Konstantin

  parent reply	other threads:[~2017-11-08  9:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  6:17 [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Jia He
2017-11-08  6:17 ` [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Jia He
2017-11-08  7:27   ` Jerin Jacob
2017-11-08  9:49   ` Ananyev, Konstantin [this message]
2017-11-08  6:17 ` [dpdk-dev] [PATCH 3/3] config: support C11 memory model for arm64 Jia He
2017-11-08  7:17 ` [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() Jerin Jacob
2017-11-08 10:28 ` Bruce Richardson
2017-11-09  1:22   ` Jia He
2017-11-09  3:14     ` Jia He
2017-11-09  3:21       ` Jianbo Liu
2017-11-09  4:43         ` Jia He
2017-11-09  4:56           ` Jianbo Liu
2017-11-09  9:38             ` Ananyev, Konstantin
2017-11-09  9:58               ` Jianbo Liu
2017-11-09 10:08                 ` Ananyev, Konstantin
2017-11-10  2:06               ` Jia He
2017-11-10  3:09                 ` Jianbo Liu
2017-11-10 10:06                 ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB9772585FABAC40@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=bing.zhao@hxt-semitech.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hejianet@gmail.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jia.he@hxt-semitech.com \
    --cc=jianbo.liu@arm.com \
    --cc=jie2.liu@hxt-semitech.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).