From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: em path performance fix
Date: Tue, 15 Mar 2016 16:06:46 +0000 [thread overview]
Message-ID: <3042915272161B4EB253DA4D77EB373A14E6BE0E@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <4500844.l7uGIisiEg@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, March 15, 2016 15:50
> To: Kulasek, TomaszX <tomaszx.kulasek@intel.com>; Maciej Czekaj
> <maciej.czekaj@caviumnetworks.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: em path performance fix
>
> 2016-03-15 14:31, Kulasek, TomaszX:
> > From: Kulasek, TomaszX
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > There is an error:
> > > > examples/l3fwd/l3fwd_em_hlm_sse.h:72:38: error:
> > > > incompatible type for argument 2 of ‘_mm_and_si128’
> > >
> > > It's caused by
> > >
> > > commit 64d3955de1de4d7879a0930a6d2f501369d3445a
> > > Author: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> > > Date: Thu Mar 10 17:06:22 2016 +0100
> > >
> > > examples/l3fwd: fix ARM build
> > >
> > > Enable NEON support in exact match mode.
> > > l3fwd example did not compile on ARM due to SSE2 instrincics used
> > > in generic part.
> > > Some instrinsins were used to initialize data structures and
> > > those were
> > > replaced by ordinary structure initalization.
> > > All SSE2 intrinsics used in forwarding, i.e. masking the IP/TCP
> header
> > > are moved to single inline function and made arch-specific.
> > >
> > > Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> > >
> > > Which doesn't include rework of l3fwd_em_hlm_sse.h file.
> > >
> > > When you compile it now with global "#define HASH_MULTI_LOOKUP 1"
> > > and alternative classification is used, and compilation will also fail
> now.
> > >
> > > I need a little bit more time to investigate it, because I'm not an
> > > expert in ARM. It will be nice if Maciej will help me in that.
> > >
> > > Tomasz
> >
> > Will be that ok for you to disable this path for arm?
>
> Please, what do you mean?
> Maciej, have you looked at this issue?
This fix uses platform specific part of code which wasn't reworked in previous patch for ARM. It causes compilation error.
What I mean, is to leave current classification path for ARM and turn on alternative only for Intel platform.
Like that:
60 +#if defined(NO_HASH_MULTI_LOOKUP) || defined(__ARM_NEON)
61 #include "l3fwd_em_sse.h"
62 #else
63 #include "l3fwd_em_hlm_sse.h"
next prev parent reply other threads:[~2016-03-15 16:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 17:23 [dpdk-dev] [PATCH] " Tomasz Kulasek
2016-03-07 6:19 ` Xu, Qian Q
2016-03-08 12:58 ` [dpdk-dev] [PATCH v2] " Tomasz Kulasek
2016-03-11 11:14 ` Thomas Monjalon
2016-03-11 12:28 ` Kulasek, TomaszX
2016-03-11 12:10 ` [dpdk-dev] [PATCH v3] " Tomasz Kulasek
2016-03-11 16:23 ` Thomas Monjalon
2016-03-11 17:48 ` Kulasek, TomaszX
2016-03-15 14:31 ` Kulasek, TomaszX
2016-03-15 14:49 ` Thomas Monjalon
2016-03-15 16:06 ` Kulasek, TomaszX [this message]
2016-03-15 19:42 ` [dpdk-dev] Odp.: " Czekaj, Maciej
2016-03-18 9:36 ` [dpdk-dev] [PATCH v4] " Tomasz Kulasek
2016-03-18 9:43 ` Kulasek, TomaszX
2016-03-18 9:52 ` [dpdk-dev] [PATCH v5] " Tomasz Kulasek
2016-03-18 10:04 ` Thomas Monjalon
2016-03-18 10:52 ` Jerin Jacob
2016-03-18 11:00 ` Thomas Monjalon
2016-03-18 11:16 ` [dpdk-dev] [PATCH] examples/l3fwd: prefer probed NEON flag to ARM gcc flag Thomas Monjalon
2016-03-18 11:20 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-03-18 11:56 ` [dpdk-dev] [PATCH v5] examples/l3fwd: em path performance fix Jan Viktorin
2016-03-18 12:45 ` Kulasek, TomaszX
2016-03-18 12:50 ` Jan Viktorin
2016-03-18 13:31 ` [dpdk-dev] [PATCH v6] " Tomasz Kulasek
2016-03-21 11:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3042915272161B4EB253DA4D77EB373A14E6BE0E@IRSMSX102.ger.corp.intel.com \
--to=tomaszx.kulasek@intel.com \
--cc=dev@dpdk.org \
--cc=maciej.czekaj@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).