From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] examples/l3fwd: em path performance fix
Date: Fri, 18 Mar 2016 09:43:25 +0000 [thread overview]
Message-ID: <3042915272161B4EB253DA4D77EB373A14E6C647@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1458293807-2604-1-git-send-email-tomaszx.kulasek@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek
> Sent: Friday, March 18, 2016 10:37
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4] examples/l3fwd: em path performance fix
>
> It seems that for the most use cases, previous hash_multi_lookup provides
> better performance, and more, sequential lookup can cause significant
> performance drop.
>
> This patch sets previously optional hash_multi_lookup method as default.
> It also provides some minor optimizations such as queue drain only on used
> tx ports.
>
>
> This patch should be applied after Maciej Czekaj's patch "l3fwd: Fix
> compilation with HASH_MULTI_LOOKUP"
>
>
> v4 changes:
> - rebased to be applicable after patch "l3fwd: Fix compilation with
> HASH_MULTI_LOOKUP" of Maciej Czekaj
>
> v3 changes:
> - "lpm: extend IPv4 next hop field" patch extends dst_port table from
> uint16_t to uint32_t omiting previously disabled l3fwd_em_hlm_sse.h,
> what causes incompatible pointer type error after turning on this
> header
>
> v2 changes:
> - fixed copy-paste error causing that not all packets are classified
> right
> in hash_multi_lookup implementation when burst size is not divisible
> by 8
>
> Fixes: 94c54b4158d5 ("examples/l3fwd: rework exact-match")
>
> Reported-by: Qian Xu <qian.q.xu@intel.com>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> examples/l3fwd/l3fwd.h | 8 ++++++++
> examples/l3fwd/l3fwd_em.c | 6 +++---
> examples/l3fwd/l3fwd_em_hlm_sse.h | 28 ++++++++++------------------
> examples/l3fwd/l3fwd_em_sse.h | 9 +++++++++
> examples/l3fwd/l3fwd_lpm.c | 4 ++--
> examples/l3fwd/main.c | 7 +++++++
> 6 files changed, 39 insertions(+), 23 deletions(-)
>
Self NACK - I forgot to remove debug options
next prev parent reply other threads:[~2016-03-18 9:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 17:23 [dpdk-dev] [PATCH] " Tomasz Kulasek
2016-03-07 6:19 ` Xu, Qian Q
2016-03-08 12:58 ` [dpdk-dev] [PATCH v2] " Tomasz Kulasek
2016-03-11 11:14 ` Thomas Monjalon
2016-03-11 12:28 ` Kulasek, TomaszX
2016-03-11 12:10 ` [dpdk-dev] [PATCH v3] " Tomasz Kulasek
2016-03-11 16:23 ` Thomas Monjalon
2016-03-11 17:48 ` Kulasek, TomaszX
2016-03-15 14:31 ` Kulasek, TomaszX
2016-03-15 14:49 ` Thomas Monjalon
2016-03-15 16:06 ` Kulasek, TomaszX
2016-03-15 19:42 ` [dpdk-dev] Odp.: " Czekaj, Maciej
2016-03-18 9:36 ` [dpdk-dev] [PATCH v4] " Tomasz Kulasek
2016-03-18 9:43 ` Kulasek, TomaszX [this message]
2016-03-18 9:52 ` [dpdk-dev] [PATCH v5] " Tomasz Kulasek
2016-03-18 10:04 ` Thomas Monjalon
2016-03-18 10:52 ` Jerin Jacob
2016-03-18 11:00 ` Thomas Monjalon
2016-03-18 11:16 ` [dpdk-dev] [PATCH] examples/l3fwd: prefer probed NEON flag to ARM gcc flag Thomas Monjalon
2016-03-18 11:20 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-03-18 11:56 ` [dpdk-dev] [PATCH v5] examples/l3fwd: em path performance fix Jan Viktorin
2016-03-18 12:45 ` Kulasek, TomaszX
2016-03-18 12:50 ` Jan Viktorin
2016-03-18 13:31 ` [dpdk-dev] [PATCH v6] " Tomasz Kulasek
2016-03-21 11:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3042915272161B4EB253DA4D77EB373A14E6C647@IRSMSX102.ger.corp.intel.com \
--to=tomaszx.kulasek@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).