From: "Wiles, Keith" <keith.wiles@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pmatilai@redhat.com" <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface
Date: Sun, 18 Sep 2016 16:20:12 +0000 [thread overview]
Message-ID: <73B08964-0730-4A1A-90DC-5C29D6A59419@intel.com> (raw)
In-Reply-To: <20160918132556.GH23158@yliu-dev.sh.intel.com>
Regards,
Keith
> On Sep 18, 2016, at 8:25 AM, Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote:
>
> On Fri, Sep 16, 2016 at 11:22:13AM -0500, Keith Wiles wrote:
>> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces
>> on the local host. The PMD allows for DPDK and the host to
>> communicate using a raw device interface on the host and in
>> the DPDK application. The device created is a Tap device with
>> a L2 packet header.
>>
>> v2 - merge all of the patches into one patch.
>> Fix a typo on naming the tap device.
>> Update the maintainers list
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>
> Hi,
>
> FYI, my robot caught some build errors with this patch applied.
All of the below errors are from Linux header files and not the Tap driver. How are you building DPDK, which config file are you using, OS version, .... Some details would be nice to understand how these errors are being generated and how I can recreate them.
>
> --yliu
>
> ---
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:71:2: error: redefinition of enumerator 'IFF_UP'
> IFF_UP = 1<<0, /* sysfs */
> ^
> /usr/include/net/if.h:45:17: note: expanded from macro 'IFF_UP'
> # define IFF_UP IFF_UP
> ^
> /usr/include/net/if.h:44:5: note: previous definition is here
> IFF_UP = 0x1, /* Interface is up. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:72:2: error: redefinition of enumerator 'IFF_BROADCAST'
> IFF_BROADCAST = 1<<1, /* __volatile__ */
> ^
> /usr/include/net/if.h:47:24: note: expanded from macro 'IFF_BROADCAST'
> # define IFF_BROADCAST IFF_BROADCAST
> ^
> /usr/include/net/if.h:46:5: note: previous definition is here
> IFF_BROADCAST = 0x2, /* Broadcast address valid. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:73:2: error: redefinition of enumerator 'IFF_DEBUG'
> IFF_DEBUG = 1<<2, /* sysfs */
> ^
> /usr/include/net/if.h:49:20: note: expanded from macro 'IFF_DEBUG'
> # define IFF_DEBUG IFF_DEBUG
> ^
> /usr/include/net/if.h:48:5: note: previous definition is here
> IFF_DEBUG = 0x4, /* Turn on debugging. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:74:2: error: redefinition of enumerator 'IFF_LOOPBACK'
> IFF_LOOPBACK = 1<<3, /* __volatile__ */
> ^
> /usr/include/net/if.h:51:23: note: expanded from macro 'IFF_LOOPBACK'
> # define IFF_LOOPBACK IFF_LOOPBACK
> ^
> /usr/include/net/if.h:50:5: note: previous definition is here
> IFF_LOOPBACK = 0x8, /* Is a loopback net. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:75:2: error: redefinition of enumerator 'IFF_POINTOPOINT'
> IFF_POINTOPOINT = 1<<4, /* __volatile__ */
> ^
> /usr/include/net/if.h:53:26: note: expanded from macro 'IFF_POINTOPOINT'
> # define IFF_POINTOPOINT IFF_POINTOPOINT
> ^
> /usr/include/net/if.h:52:5: note: previous definition is here
> IFF_POINTOPOINT = 0x10, /* Interface is point-to-point link. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:76:2: error: redefinition of enumerator 'IFF_NOTRAILERS'
> IFF_NOTRAILERS = 1<<5, /* sysfs */
> ^
> /usr/include/net/if.h:55:25: note: expanded from macro 'IFF_NOTRAILERS'
> # define IFF_NOTRAILERS IFF_NOTRAILERS
> ^
> /usr/include/net/if.h:54:5: note: previous definition is here
> IFF_NOTRAILERS = 0x20, /* Avoid use of trailers. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:77:2: error: redefinition of enumerator 'IFF_RUNNING'
> IFF_RUNNING = 1<<6, /* __volatile__ */
> ^
> /usr/include/net/if.h:57:22: note: expanded from macro 'IFF_RUNNING'
> # define IFF_RUNNING IFF_RUNNING
> ^
> /usr/include/net/if.h:56:5: note: previous definition is here
> IFF_RUNNING = 0x40, /* Resources allocated. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:78:2: error: redefinition of enumerator 'IFF_NOARP'
> IFF_NOARP = 1<<7, /* sysfs */
> ^
> /usr/include/net/if.h:59:20: note: expanded from macro 'IFF_NOARP'
> # define IFF_NOARP IFF_NOARP
> ^
> /usr/include/net/if.h:58:5: note: previous definition is here
> IFF_NOARP = 0x80, /* No address resolution protocol. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:79:2: error: redefinition of enumerator 'IFF_PROMISC'
> IFF_PROMISC = 1<<8, /* sysfs */
> ^
> /usr/include/net/if.h:61:22: note: expanded from macro 'IFF_PROMISC'
> # define IFF_PROMISC IFF_PROMISC
> ^
> /usr/include/net/if.h:60:5: note: previous definition is here
> IFF_PROMISC = 0x100, /* Receive all packets. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:80:2: error: redefinition of enumerator 'IFF_ALLMULTI'
> IFF_ALLMULTI = 1<<9, /* sysfs */
> ^
> /usr/include/net/if.h:65:23: note: expanded from macro 'IFF_ALLMULTI'
> # define IFF_ALLMULTI IFF_ALLMULTI
> ^
> /usr/include/net/if.h:64:5: note: previous definition is here
> IFF_ALLMULTI = 0x200, /* Receive all multicast packets. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:81:2: error: redefinition of enumerator 'IFF_MASTER'
> IFF_MASTER = 1<<10, /* __volatile__ */
> ^
> /usr/include/net/if.h:68:21: note: expanded from macro 'IFF_MASTER'
> # define IFF_MASTER IFF_MASTER
> ^
> /usr/include/net/if.h:67:5: note: previous definition is here
> IFF_MASTER = 0x400, /* Master of a load balancer. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:82:2: error: redefinition of enumerator 'IFF_SLAVE'
> IFF_SLAVE = 1<<11, /* __volatile__ */
> ^
> /usr/include/net/if.h:70:20: note: expanded from macro 'IFF_SLAVE'
> # define IFF_SLAVE IFF_SLAVE
> ^
> /usr/include/net/if.h:69:5: note: previous definition is here
> IFF_SLAVE = 0x800, /* Slave of a load balancer. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:83:2: error: redefinition of enumerator 'IFF_MULTICAST'
> IFF_MULTICAST = 1<<12, /* sysfs */
> ^
> /usr/include/net/if.h:73:24: note: expanded from macro 'IFF_MULTICAST'
> # define IFF_MULTICAST IFF_MULTICAST
> ^
> /usr/include/net/if.h:72:5: note: previous definition is here
> IFF_MULTICAST = 0x1000, /* Supports multicast. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:84:2: error: redefinition of enumerator 'IFF_PORTSEL'
> IFF_PORTSEL = 1<<13, /* sysfs */
> ^
> /usr/include/net/if.h:76:22: note: expanded from macro 'IFF_PORTSEL'
> # define IFF_PORTSEL IFF_PORTSEL
> ^
> /usr/include/net/if.h:75:5: note: previous definition is here
> IFF_PORTSEL = 0x2000, /* Can set media type. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:85:2: error: redefinition of enumerator 'IFF_AUTOMEDIA'
> IFF_AUTOMEDIA = 1<<14, /* sysfs */
> ^
> /usr/include/net/if.h:78:24: note: expanded from macro 'IFF_AUTOMEDIA'
> # define IFF_AUTOMEDIA IFF_AUTOMEDIA
> ^
> /usr/include/net/if.h:77:5: note: previous definition is here
> IFF_AUTOMEDIA = 0x4000, /* Auto media select active. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:86:2: error: redefinition of enumerator 'IFF_DYNAMIC'
> IFF_DYNAMIC = 1<<15, /* sysfs */
> ^
> /usr/include/net/if.h:80:22: note: expanded from macro 'IFF_DYNAMIC'
> # define IFF_DYNAMIC IFF_DYNAMIC
> ^
> /usr/include/net/if.h:79:5: note: previous definition is here
> IFF_DYNAMIC = 0x8000 /* Dialup device with changing addresses. */
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:169:8: error: redefinition of 'ifmap'
> struct ifmap {
> ^
> /usr/include/net/if.h:111:8: note: previous definition is here
> struct ifmap
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:203:8: error: redefinition of 'ifreq'
> struct ifreq {
> ^
> /usr/include/net/if.h:126:8: note: previous definition is here
> struct ifreq
> ^
> In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50:
> /usr/include/linux/if.h:252:8: error: redefinition of 'ifconf'
> struct ifconf {
> ^
> /usr/include/net/if.h:176:8: note: previous definition is here
> struct ifconf
> ^
> 19 errors generated.
> make[6]: *** [rte_eth_tap.o] Error 1
> make[5]: *** [tap] Error 2
> make[5]: *** Waiting for unfinished jobs....
> make[4]: *** [net] Error 2
> make[3]: *** [drivers] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [pre_install] Error 2
> make: *** [install] Error 2
> error: build failed
next prev parent reply other threads:[~2016-09-18 16:20 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 14:10 [dpdk-dev] [PATCH 1/3] " Keith Wiles
2016-09-15 14:10 ` [dpdk-dev] [PATCH 2/3] docs:tun/tap PMD information Keith Wiles
2016-09-15 14:13 ` Wiles, Keith
2016-09-15 14:15 ` Wiles, Keith
2016-09-21 2:00 ` [dpdk-dev] [PATCH v3] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-10-04 14:45 ` [dpdk-dev] [PATCH v4] " Keith Wiles
2016-10-11 9:40 ` Ferruh Yigit
2016-10-11 11:30 ` Michał Mirosław
2016-10-11 20:56 ` Wiles, Keith
2016-10-12 8:14 ` Michał Mirosław
2016-10-11 11:49 ` Ferruh Yigit
2016-10-11 21:07 ` Wiles, Keith
2016-10-11 12:28 ` Ferruh Yigit
2016-10-11 20:57 ` Wiles, Keith
2016-10-11 21:51 ` [dpdk-dev] [PATCH v5] " Keith Wiles
2016-10-12 14:56 ` Ferruh Yigit
2016-10-12 18:19 ` Wiles, Keith
2016-10-12 19:57 ` Wiles, Keith
2016-10-12 20:54 ` [dpdk-dev] [PATCH v6] " Keith Wiles
2016-10-13 14:41 ` Ferruh Yigit
2016-10-13 15:36 ` [dpdk-dev] [PATCH v7] " Keith Wiles
2016-10-13 16:11 ` [dpdk-dev] [PATCH v8] " Keith Wiles
2016-10-13 16:33 ` Mcnamara, John
2016-10-13 22:03 ` [dpdk-dev] [PATCH v9] " Keith Wiles
2016-10-14 6:41 ` Mcnamara, John
2016-10-14 9:39 ` Ferruh Yigit
2016-11-21 12:56 ` Ferruh Yigit
2016-11-25 19:38 ` Aws Ismail
2016-11-29 21:36 ` Aws Ismail
2016-11-29 22:16 ` Wiles, Keith
2016-12-07 19:38 ` [dpdk-dev] [PATCH v10] drivers/net:new TUN/TAP device PMD Keith Wiles
2016-12-07 20:15 ` Aws Ismail
2016-12-09 18:16 ` Ferruh Yigit
2016-12-09 19:05 ` [dpdk-dev] [PATCH v11] " Keith Wiles
2016-12-12 12:39 ` Vasily Philipov
2016-12-12 14:24 ` [dpdk-dev] [PATCH v12] net/tap: new " Keith Wiles
2016-12-12 14:38 ` Keith Wiles
2016-12-12 19:13 ` Marc
2016-12-12 21:09 ` Wiles, Keith
2016-12-13 13:54 ` Ferruh Yigit
2017-01-20 12:14 ` Ferruh Yigit
2017-01-20 14:25 ` [dpdk-dev] [PATCH] net/tap: fix IFF_MULTI_QUEUE in older kernels not found Keith Wiles
2017-01-20 14:30 ` Keith Wiles
2017-01-20 16:11 ` Ferruh Yigit
2017-01-20 17:37 ` Thomas Monjalon
2016-09-15 14:10 ` [dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver Keith Wiles
2016-09-16 7:36 ` Panu Matilainen
2016-09-16 14:46 ` Wiles, Keith
2016-09-16 16:22 ` [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface Keith Wiles
2016-09-18 13:25 ` Yuanhan Liu
2016-09-18 16:20 ` Wiles, Keith [this message]
2016-09-19 0:29 ` Yuanhan Liu
2016-09-19 15:56 ` Wiles, Keith
2016-09-20 3:54 ` Yuanhan Liu
2016-09-20 4:05 ` Yuanhan Liu
2016-09-21 1:32 ` Wiles, Keith
2016-09-21 2:13 ` Yuanhan Liu
2016-09-21 8:24 ` Thomas Monjalon
2016-09-21 23:55 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73B08964-0730-4A1A-90DC-5C29D6A59419@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).