From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF
Date: Mon, 27 Mar 2017 10:37:34 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E01315C143B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D14A62@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, March 27, 2017 5:55 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v2 3/4] net/i40e: support tunnel filter to VF
>
>
>
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Thursday, March 23, 2017 6:46 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org
> > Subject: [PATCH v2 3/4] net/i40e: support tunnel filter to VF
> >
> > Previously, only tunnel filter to PF is supported.
> > This patch adds i40e_dev_consistent_tunnel_filter_set
> > function for consistent filter API to support tunnel filter to VF.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 145
> > +++++++++++++++++++++++++++++++++++++++++
> > drivers/net/i40e/i40e_ethdev.h | 32 +++++++++
> > drivers/net/i40e/i40e_flow.c | 50 +++++++++-----
> > 3 files changed, 212 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 5e6cc59..2b3d41b 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -6935,6 +6935,151 @@ i40e_dev_tunnel_filter_set(struct i40e_pf *pf,
> > return ret;
> > }
> >
> > +int
> > +i40e_dev_consistent_tunnel_filter_set(struct i40e_pf *pf,
> > + struct i40e_tunnel_filter_conf *tunnel_filter,
> > + uint8_t add)
> > +{
> > + uint16_t ip_type;
> > + uint32_t ipv4_addr;
> > + uint8_t i, tun_type = 0;
> > + /* internal variable to convert ipv6 byte order */
> > + uint32_t convert_ipv6[4];
> > + int val, ret = 0;
> > + struct i40e_pf_vf *vf = NULL;
> > + struct i40e_hw *hw = I40E_PF_TO_HW(pf);
> > + struct i40e_vsi *vsi;
> > + struct i40e_aqc_add_rm_cloud_filt_elem_ext *cld_filter;
> > + struct i40e_aqc_add_rm_cloud_filt_elem_ext *pfilter;
> > + struct i40e_tunnel_rule *tunnel_rule = &pf->tunnel;
> > + struct i40e_tunnel_filter *tunnel, *node;
> > + struct i40e_tunnel_filter check_filter; /* Check if filter exists */
> > + bool big_buffer = 0;
> > +
> > + cld_filter = rte_zmalloc("tunnel_filter",
> > + sizeof(struct
> i40e_aqc_add_rm_cloud_filt_elem_ext),
> > + 0);
> > +
> > + if (cld_filter == NULL) {
> > + PMD_DRV_LOG(ERR, "Failed to alloc memory.");
> > + return -EINVAL;
> -EINVAL? I think -ENOMEM is better.
Agree.
>
>
> > + if (add) {
> > + if (big_buffer)
> > + ret = i40e_aq_add_cloud_filters_big_buffer(hw,
> > + vsi->seid, cld_filter, 1);
> > + else
> > + ret = i40e_aq_add_cloud_filters(hw,
> > + vsi->seid, &cld_filter->element, 1);
> > + if (ret < 0) {
> > + PMD_DRV_LOG(ERR, "Failed to add a tunnel filter.");
> > + return ret;
> Ret is type of "enum i40e_status_code". It will not be consistent.
>
>
> > +
> > #define I40E_MIRROR_MAX_ENTRIES_PER_RULE 64
> > #define I40E_MAX_MIRROR_RULES 64
> > /*
> > @@ -718,6 +746,7 @@ union i40e_filter_t {
> > struct rte_eth_ethertype_filter ethertype_filter;
> > struct rte_eth_fdir_filter fdir_filter;
> > struct rte_eth_tunnel_filter_conf tunnel_filter;
> > + struct i40e_tunnel_filter_conf consistent_tunnel_filter;
> > };
> >
> I like to use driver specified structures instead of the old rte_eth_XX.
> Glad to see this change, it will be better to change other structs. :)
Thanks, what do you think we change other structures after this release?
>
> Acked-by Jingjing Wu <jingjing.wu@intel.com>
>
> Thanks
> Jingjing
next prev parent reply other threads:[~2017-03-27 10:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 9:31 [dpdk-dev] [PATCH 0/4] support replace filter function Beilei Xing
2017-03-03 9:31 ` [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 5:59 ` Xing, Beilei
2017-03-09 10:01 ` Ferruh Yigit
2017-03-09 10:43 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 2/4] net/i40e: rework tunnel filter functions Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:00 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:08 ` Xing, Beilei
2017-03-27 16:34 ` Ferruh Yigit
2017-03-03 9:31 ` [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:11 ` Xing, Beilei
2017-03-08 15:50 ` [dpdk-dev] [PATCH 0/4] support replace filter function Ferruh Yigit
2017-03-09 5:13 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 0/4] Rework tunnel filter functions Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 1/4] net/i40e: rework " Beilei Xing
2017-03-27 9:47 ` Wu, Jingjing
2017-03-27 10:33 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-27 9:54 ` Wu, Jingjing
2017-03-27 10:37 ` Xing, Beilei [this message]
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 1/4] net/i40e: rework " Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 1/4] net/i40e: rework " Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-29 13:23 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Wu, Jingjing
2017-03-30 13:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E01315C143B@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).