From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Liu, Yong" <yong.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF
Date: Mon, 27 Mar 2017 17:34:24 +0100 [thread overview]
Message-ID: <9d5800ef-eedf-c75f-302d-b38781c6598c@intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E01315A7D2C@SHSMSX101.ccr.corp.intel.com>
On 3/9/2017 6:08 AM, Xing, Beilei wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, March 8, 2017 11:50 PM
>> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Iremonger,
>> Bernard <bernard.iremonger@intel.com>; Liu, Yong <yong.liu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF
>>
>> On 3/3/2017 9:31 AM, Beilei Xing wrote:
>>> This patch is to support tunnel filter to VF.
>>>
>>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>>> Signed-off-by: Yong Liu <yong.liu@intel.com>
>>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>>> ---
>>
>> <...>
>>
>>> +/**
>>> + * Tunneling Packet filter configuration.
>>> + */
>>> +struct i40e_tunnel_filter_conf {
>>
>> There is already "rte_eth_tunnel_filter_conf", why driver is creating its own
>> version of structure instead of using / updating public one?
>
> Marvin has an announcement for this change before, but it's rejected as consistent filter API is available.
> http://www.dpdk.org/dev/patchwork/patch/19772/
>
> So we add this new feature in PMD:
> + uint8_t is_to_vf; /**< 0 - to PF, 1 - to VF */
> + uint16_t vf_id; /**< VF id for tunnel filter insertion. */
Cc'ed Jerin and Thomas, which seems commented to Marvin's patch.
Jerin, Thomas,
Can you please comment if it is OK to localize the component and modify
it in the PMD comparing the previous updating ethdev approach?
Thanks,
ferruh
>
>
>>
>>> + struct ether_addr outer_mac; /**< Outer MAC address to match.
>> */
>>> + struct ether_addr inner_mac; /**< Inner MAC address to match. */
>>> + uint16_t inner_vlan; /**< Inner VLAN to match. */
>>> + uint32_t outer_vlan; /**< Outer VLAN to match */
>>> + enum rte_tunnel_iptype ip_type; /**< IP address type. */
>>> + /**
>>> + * Outer destination IP address to match if ETH_TUNNEL_FILTER_OIP
>>> + * is set in filter_type, or inner destination IP address to match
>>> + * if ETH_TUNNEL_FILTER_IIP is set in filter_type.
>>> + */
>>> + union {
>>> + uint32_t ipv4_addr; /**< IPv4 address in big endian. */
>>> + uint32_t ipv6_addr[4]; /**< IPv6 address in big endian. */
>>> + } ip_addr;
>>> + /** Flags from ETH_TUNNEL_FILTER_XX - see above. */
>>> + uint16_t filter_type;
>>> + enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */
>>> + uint32_t tenant_id; /**< Tenant ID to match. VNI, GRE key... */
>>> + uint16_t queue_id; /**< Queue assigned to if match. */
>>> + uint8_t is_to_vf; /**< 0 - to PF, 1 - to VF */
>>> + uint16_t vf_id; /**< VF id for tunnel filter insertion. */
>>> +};
>>> +
>>
>> <...>
next prev parent reply other threads:[~2017-03-27 16:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 9:31 [dpdk-dev] [PATCH 0/4] support replace filter function Beilei Xing
2017-03-03 9:31 ` [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 5:59 ` Xing, Beilei
2017-03-09 10:01 ` Ferruh Yigit
2017-03-09 10:43 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 2/4] net/i40e: rework tunnel filter functions Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:00 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:08 ` Xing, Beilei
2017-03-27 16:34 ` Ferruh Yigit [this message]
2017-03-03 9:31 ` [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:11 ` Xing, Beilei
2017-03-08 15:50 ` [dpdk-dev] [PATCH 0/4] support replace filter function Ferruh Yigit
2017-03-09 5:13 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 0/4] Rework tunnel filter functions Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 1/4] net/i40e: rework " Beilei Xing
2017-03-27 9:47 ` Wu, Jingjing
2017-03-27 10:33 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-27 9:54 ` Wu, Jingjing
2017-03-27 10:37 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 1/4] net/i40e: rework " Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 1/4] net/i40e: rework " Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-29 13:23 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Wu, Jingjing
2017-03-30 13:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5800ef-eedf-c75f-302d-b38781c6598c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).