From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
"Kamalakshitha Aligeri" <kamalakshitha.aligeri@arm.com>
Cc: <Yuying.Zhang@intel.com>, <beilei.xing@intel.com>,
<olivier.matz@6wind.com>, <andrew.rybchenko@oktetlabs.ru>,
<bruce.richardson@intel.com>, <konstantin.ananyev@huawei.com>,
<Honnappa.Nagarahalli@arm.com>, <ruifeng.wang@arm.com>,
<feifei.wang2@arm.com>, <dev@dpdk.org>, <nd@arm.com>
Subject: RE: [PATCH v10 1/2] mempool cache: add zero-copy get and put functions
Date: Wed, 7 Jun 2023 14:04:34 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8799C@smartserver.smartshare.dk> (raw)
In-Reply-To: <1755322.4herOUoSWf@thomas>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, 7 June 2023 12.32
>
> 24/02/2023 19:10, Kamalakshitha Aligeri:
> > From: = Morten Brørup <mb@smartsharesystems.com>
>
> There is an equal sign inserted above.
Could be removed while applying?
>
> >
> > Zero-copy access to mempool caches is beneficial for PMD performance, and
> > must be provided by the mempool library to fix [Bug 1052] without a
> > performance regression.
> >
> > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052
> >
> > Bugzilla ID: 1052
>
> It would be fun if the bug content was a link to an email :)
> More fun: refer to a place which will be deleted in some time.
> Really, please explain the problem in the patch.
> You can refer to the Bugzilla, but the idea must be in the patch.
> Then no need for the full link.
>
>
OK, how about this:
Zero-copy access to mempool caches is beneficial for PMD performance.
Furthermore, having a zero-copy mempool API is considered a precondition for fixing a certain category of bugs, present in some PMDs: For performance reasons, some PMDs had bypassed the mempool API in order to achieve zero-copy access to the mempool cache. This can only be fixed in those PMDs without a performance regression if the mempool library offers zero-copy access APIs, so the PMDs can use the proper mempool API instead of copy-pasting code from the mempool library. Furthermore, the copy-pasted code in those PMDs has not been kept up to date with the improvements of the mempool library, so when they bypass the mempool API, mempool trace is missing and mempool statistics is not updated.
Bugzilla ID: 1052
next prev parent reply other threads:[~2023-06-07 12:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:10 [PATCH v10 0/2] " Kamalakshitha Aligeri
2023-02-24 18:10 ` [PATCH v10 1/2] mempool cache: add " Kamalakshitha Aligeri
2023-02-27 7:12 ` Ruifeng Wang
2023-04-06 10:13 ` Morten Brørup
2023-04-25 13:14 ` Morten Brørup
2023-06-07 10:32 ` Thomas Monjalon
2023-06-07 12:04 ` Morten Brørup [this message]
2023-06-07 12:32 ` Thomas Monjalon
2023-06-07 13:42 ` Morten Brørup
2023-06-07 14:05 ` Morten Brørup
2023-07-05 17:18 ` [PATCH v11 " Kamalakshitha Aligeri
2023-07-05 17:18 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-06 9:20 ` Konstantin Ananyev
2023-07-06 13:32 ` Morten Brørup
2023-07-06 9:20 ` [PATCH v11 1/2] mempool cache: add zero-copy get and put functions Konstantin Ananyev
2023-07-05 18:02 ` Kamalakshitha Aligeri
2023-07-05 18:02 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-18 11:36 ` Morten Brørup
2023-07-21 16:28 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Dharmik Thakkar
2023-07-21 16:28 ` [PATCH v12 2/2] net/i40e: replace put function Dharmik Thakkar
2023-07-31 12:16 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Thomas Monjalon
2023-10-13 5:41 ` Morten Brørup
2023-07-18 10:14 ` [PATCH v11 " Morten Brørup
2023-02-24 18:10 ` [PATCH v10 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-03-02 21:44 ` Kamalakshitha Aligeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D8799C@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Yuying.Zhang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=kamalakshitha.aligeri@arm.com \
--cc=konstantin.ananyev@huawei.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).