From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: add bitrate stats option
Date: Fri, 28 Apr 2017 08:21:23 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D5A052@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1493211774-28249-1-git-send-email-remy.horton@intel.com>
> -----Original Message-----
> From: Horton, Remy
> Sent: Wednesday, April 26, 2017 9:03 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH v1] app/testpmd: add bitrate stats option
>
> Bit-rate collation should only be done by one core. This patch adds an option to
> select which core performs the bit-rate calculation, which is also disabled by
> default.
>
> Fixes: 7e4441c8efb9 ("app/testpmd: add bitrate statistics calculation")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
> app/test-pmd/parameters.c | 15 +++++++++++++++
> app/test-pmd/testpmd.c | 36 ++++++++++++++++++++++++++----------
> app/test-pmd/testpmd.h | 5 +++++
> 3 files changed, 46 insertions(+), 10 deletions(-)
>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> 3f4d3a2..a6140b5 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -536,6 +536,9 @@ launch_args_parse(int argc, char** argv) #ifdef
> RTE_LIBRTE_LATENCY_STATS
> { "latencystats", 1, 0, 0 },
> #endif
> +#ifdef RTE_LIBRTE_BITRATE
> + { "bitratestats", 1, 0, 0 },
> +#endif
> { "disable-crc-strip", 0, 0, 0 },
> { "enable-lro", 0, 0, 0 },
> { "enable-rx-cksum", 0, 0, 0 },
> @@ -793,6 +796,18 @@ launch_args_parse(int argc, char** argv)
> " must be >= 0\n", n);
> }
Please add description printing in function usage.
> #ifdef RTE_LIBRTE_LATENCY_STATS
> @@ -2238,6 +2248,9 @@ main(int argc, char** argv)
> rte_panic("Empty set of forwarding logical cores - check the "
> "core mask supplied in the command parameters\n");
>
> + /* Bitrate stats disabled by default */
> + bitrate_enabled = 0;
You can assign it at the definition.
> +
Don't forget the testpmd doc to describe the parameters.
Thanks
Jingjing
next prev parent reply other threads:[~2017-04-28 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 13:02 Remy Horton
2017-04-28 8:21 ` Wu, Jingjing [this message]
2017-04-28 11:00 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-05-01 13:49 ` Thomas Monjalon
2017-05-01 20:07 ` Patil, Harish
2017-05-01 20:22 ` Thomas Monjalon
2017-05-02 11:18 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D5A052@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).