From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Patil, Harish" <Harish.Patil@cavium.com>,
"Horton, Remy" <remy.horton@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option
Date: Tue, 2 May 2017 11:18:52 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747814CE8@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1984316.gczFh5jcb3@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 01, 2017 9:22 PM
> To: Patil, Harish; Horton, Remy
> Cc: dev@dpdk.org; De Lara Guarch, Pablo; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add bitrate stats option
>
> 01/05/2017 22:07, Patil, Harish:
> > Hi Remy,
> > Have a small suggestion here.
> > Since testpmd uses new libraries of librte_latencystats and
> > librte_bitratestats it hurts packet processing performance.
> > Many users who use testpmd to do the initial performance benchmarks
> may
> > not be aware of such a feature is default enabled.
>
> Yes, the default config of testpmd must give good performance.
>
> > So can we disable this feature by default in the config?
> > * CONFIG_RTE_LIBRTE_BITRATE=n
> > * CONFIG_RTE_LIBRTE_LATENCY_STATS=n
> > Only those folks interested in latency/jitter measurements can recompile
> > with those configs enabled.
>
> I disagree about compile-time options.
> It should be a run-time option of testpmd.
>
> Please Remy (or others),
> disable the metrics in the default configuration of testpmd,
> before the 17.05 release.
> You have few days, it is urgent.
Bitrate stats are disabled by default, in testpmd.
I assume that the code that you want to avoid is:
for (sm_id = 0; sm_id < nb_fs; sm_id++)
(*pkt_fwd)(fsm[sm_id]);
#ifdef RTE_LIBRTE_BITRATE
if (bitrate_enabled != 0 &&
bitrate_lcore_id == rte_lcore_id()) {
tics_current = rte_rdtsc();
if (tics_current - tics_datum >= tics_per_1sec) {
Unless --bitrate-stats is used, bitrate_enabled = 0, so all this code won't be run.
I can send a patch to check the latencystats_enabled flag first, following the approach above, here:
#ifdef RTE_LIBRTE_LATENCY_STATS
if (latencystats_lcore_id == rte_lcore_id())
Thanks,
Pablo
prev parent reply other threads:[~2017-05-02 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 13:02 [dpdk-dev] [PATCH v1] " Remy Horton
2017-04-28 8:21 ` Wu, Jingjing
2017-04-28 11:00 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-05-01 13:49 ` Thomas Monjalon
2017-05-01 20:07 ` Patil, Harish
2017-05-01 20:22 ` Thomas Monjalon
2017-05-02 11:18 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747814CE8@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=Harish.Patil@cavium.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=remy.horton@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).