From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Chilikin, Andrey" <andrey.chilikin@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush
Date: Wed, 6 Sep 2017 07:21:17 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07C61CE2@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <AAC06825A3B29643AF5372F5E0DDF0538DC3FB85@IRSMSX106.ger.corp.intel.com>
Hi, Andrey
> -----Original Message-----
> From: Chilikin, Andrey
> Sent: Wednesday, September 6, 2017 7:52 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Wednesday, August 23, 2017 8:26 PM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush
> >
> > This feature enable queue regions configuration for RSS in PF/VF, so
> > that different traffic classes or different packet classification
> > types can be separated to different queues in different queue
> > regions.This patch can set queue region range, it include queue number
> > in a region and the index of first queue.
> > This patch enable mapping between different priorities (UP) and
> > different traffic classes.It also enable mapping between a region
> > index and a sepcific flowtype(PCTYPE).It also provide the solution of
> > flush all configuration about queue region the above described.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.h | 6 +
> > drivers/net/i40e/rte_pmd_i40e.c | 287
> > ++++++++++++++++++++++++++++++
> > drivers/net/i40e/rte_pmd_i40e.h | 39 ++++
> > drivers/net/i40e/rte_pmd_i40e_version.map | 7 +
> > 4 files changed, 339 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > b/drivers/net/i40e/i40e_ethdev.h index 48abc05..1d6e9b2 100644
> > --- a/drivers/net/i40e/i40e_ethdev.h
> > +++ b/drivers/net/i40e/i40e_ethdev.h
> > @@ -260,6 +260,12 @@ enum i40e_flxpld_layer_idx { #define
> > I40E_QOS_BW_WEIGHT_MIN 1
> > /* The max bandwidth weight is 127. */ #define
> > I40E_QOS_BW_WEIGHT_MAX 127
> > +/* The max queue region index is 7. */ #define
> > +I40E_TCREGION_MAX_INDEX 7
> > +/* The max queue region userpriority is 7. */ #define
> > +I40E_REGION_USERPRIORITY_MAX_INDEX 7
> > +/* The max pctype index is 63. */
> > +#define I40E_REGION_PCTYPE_MAX_INDEX 63
> >
> > /**
> > * The overhead from MTU to max frame size.
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> > b/drivers/net/i40e/rte_pmd_i40e.c index 950a0d6..5d1e1d4 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.c
> > +++ b/drivers/net/i40e/rte_pmd_i40e.c
> > @@ -2117,3 +2117,290 @@ int
> > rte_pmd_i40e_ptype_mapping_replace(uint8_t port,
> >
> > return 0;
> > }
> > +
> > +static int
> > +i40e_set_queue_region(struct i40e_hw *hw, struct i40e_pf *pf,
> > + struct rte_i40e_rss_region_conf *conf_ptr) {
> > + uint32_t TCREGION, TC_OFFSET, TC_SIZE;
> Please follow DPDK coding style guide and use only low case for variables
> names.
>
> > + uint16_t TC_SIZE_TB[7] = {1, 2, 4, 8, 16, 32, 64};
> > + uint16_t i, index;
> > + uint16_t main_vsi_seid = pf->main_vsi_seid;
>
> <snip>
>
> >
> > /**
> > @@ -146,6 +159,19 @@ struct rte_pmd_i40e_ptype_mapping { };
> >
> > /**
> > + * Queue region information get from CLI.
> > + */
> > +struct rte_i40e_rss_region_conf {
> > + uint8_t region_id;
> > + uint8_t flowtype;
> As this is internal i40e flow type (PCTYPE), it is better name it hw_flowtype.
> As an option - use RTE level sw_flowtype and map it to internal hw_flowtype
> using corresponding i40e API.
Ok, I will change that name to " hw_flowtype " in v2 patch set.
>
> > + uint8_t queue_startIndex;
> > + uint8_t queue_num;
> > + uint8_t UserPriority;
> Low case for naming.
Ok, I will change code style in v2 patch set.
>
> > + uint8_t TrafficClasses;
> > + enum rte_pmd_i40e_queue_region_op op; };
> > +
> > +/**
> > * Notify VF when PF link status changes.
> > *
> > * @param port
> > @@ -637,4 +663,17 @@ int
> rte_pmd_i40e_ptype_mapping_replace(uint8_t
> > port,
> > uint8_t mask,
> > uint32_t pkt_type);
> >
> > +/**
> > + * Get RSS queue region info from CLI and do configuration for
> > + * that port as the command otion type
> > + *
> > + * @param port
> > + * pointer to port identifier of the device
> > + * @param conf_ptr
> > + * pointer to the struct that contain all the
> > + * region configuration parameters
> > + */
> > +int rte_pmd_i40e_queue_region_conf(uint8_t port,
> > + struct rte_i40e_rss_region_conf *conf_ptr);
> > +
> > #endif /* _PMD_I40E_H_ */
> > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map
> > b/drivers/net/i40e/rte_pmd_i40e_version.map
> > index 20cc980..77ac385 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e_version.map
> > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map
> > @@ -45,3 +45,10 @@ DPDK_17.08 {
> > rte_pmd_i40e_get_ddp_info;
> >
> > } DPDK_17.05;
> > +
> > +DPDK_17.11 {
> > + global:
> > +
> > + rte_pmd_i40e_queue_region_conf;
> > +
> > +} DPDK_17.08;
> > --
> > 2.9.3
next prev parent reply other threads:[~2017-09-06 7:23 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 3:26 [dpdk-dev] [PATCH 0/2] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-08-24 3:26 ` [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush Wei Zhao
2017-08-31 16:18 ` Ferruh Yigit
2017-09-01 2:38 ` Zhao1, Wei
2017-09-06 9:11 ` Ferruh Yigit
2017-09-15 11:00 ` Ferruh Yigit
2017-09-20 3:20 ` Zhao1, Wei
2017-09-20 10:32 ` Ferruh Yigit
2017-09-18 3:38 ` Zhao1, Wei
2017-09-05 23:52 ` Chilikin, Andrey
2017-09-06 7:21 ` Zhao1, Wei [this message]
2017-08-24 3:26 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-13 6:04 ` [dpdk-dev] [PATCH v2 0/2] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-13 6:04 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: queue region set and flush Wei Zhao
2017-09-13 6:04 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-15 3:13 ` [dpdk-dev] [PATCH v3 0/2] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-15 3:13 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush Wei Zhao
2017-09-20 10:36 ` Ferruh Yigit
2017-09-21 6:48 ` Zhao1, Wei
2017-09-21 7:10 ` Ferruh Yigit
2017-09-21 7:26 ` Zhao1, Wei
2017-09-21 15:45 ` Ferruh Yigit
2017-09-25 7:40 ` Zhao1, Wei
2017-09-25 9:31 ` Ferruh Yigit
2017-09-26 7:46 ` Zhao1, Wei
2017-09-26 8:54 ` Zhao1, Wei
2017-09-27 19:13 ` Ferruh Yigit
2017-09-28 2:40 ` Zhao1, Wei
2017-09-21 19:53 ` Chilikin, Andrey
2017-09-22 8:49 ` Zhao1, Wei
2017-09-22 20:13 ` Chilikin, Andrey
2017-09-25 2:55 ` Zhao1, Wei
2017-09-24 16:01 ` Wu, Jingjing
2017-09-25 3:26 ` Zhao1, Wei
2017-09-25 5:55 ` Zhao1, Wei
2017-09-15 3:13 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-20 10:45 ` Ferruh Yigit
2017-09-25 9:25 ` Zhao1, Wei
2017-09-25 9:43 ` Ferruh Yigit
2017-09-26 5:30 ` Zhao1, Wei
2017-09-28 9:04 ` [dpdk-dev] [PATCH v4 0/3] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-28 9:04 ` [dpdk-dev] [PATCH v4 1/3] net/i40e: queue region set and flush Wei Zhao
2017-09-28 9:04 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-28 9:04 ` [dpdk-dev] [PATCH v4 3/3] doc/testpmd_app_ug: add doc info for " Wei Zhao
2017-09-28 9:10 ` [dpdk-dev] [PATCH v4 0/3] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-28 9:10 ` [dpdk-dev] [PATCH v4 1/3] net/i40e: queue region set and flush Wei Zhao
2017-09-28 9:10 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-28 9:10 ` [dpdk-dev] [PATCH v4 3/3] doc/testpmd_app_ug: add doc info for " Wei Zhao
2017-09-29 2:56 ` [dpdk-dev] [PATCH v5 0/3] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-29 2:56 ` [dpdk-dev] [PATCH v5 1/3] net/i40e: queue region set and flush Wei Zhao
2017-09-29 4:54 ` Wu, Jingjing
2017-09-29 8:27 ` Zhao1, Wei
2017-09-29 2:56 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-29 5:04 ` Wu, Jingjing
2017-09-29 5:21 ` Zhao1, Wei
2017-09-29 2:56 ` [dpdk-dev] [PATCH v5 3/3] doc/testpmd_app_ug: add doc info for " Wei Zhao
2017-09-29 8:11 ` [dpdk-dev] [PATCH v6] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-29 8:11 ` [dpdk-dev] [PATCH v6] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-29 8:11 ` [dpdk-dev] [PATCH v6] net/i40e: queue region set and flush Wei Zhao
2017-09-29 9:00 ` Wu, Jingjing
2017-09-29 9:16 ` [dpdk-dev] [PATCH v7 0/2] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-09-29 9:16 ` [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush Wei Zhao
2017-09-29 12:22 ` Wu, Jingjing
2017-10-10 1:45 ` Zhao1, Wei
2017-10-03 17:54 ` Ferruh Yigit
2017-10-10 6:11 ` Zhao1, Wei
2017-09-29 9:16 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-09-29 14:29 ` Wu, Jingjing
2017-10-03 18:04 ` Ferruh Yigit
2017-10-10 1:46 ` Zhao1, Wei
2017-10-10 2:55 ` Zhao1, Wei
2017-10-10 3:01 ` Zhao1, Wei
2017-10-11 2:15 ` Ferruh Yigit
2017-09-29 10:15 ` [dpdk-dev] [PATCH v7 0/2] net/i40e: API to configure queue regions for RSS Peng, Yuan
2017-10-11 8:49 ` [dpdk-dev] [PATCH v8 " Wei Zhao
2017-10-11 8:49 ` [dpdk-dev] [PATCH v8 1/2] net/i40e: queue region set and flush Wei Zhao
2017-10-11 8:49 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-10-11 8:55 ` [dpdk-dev] [PATCH v8 0/2] net/i40e: API to configure queue regions for RSS Wei Zhao
2017-10-11 8:55 ` [dpdk-dev] [PATCH v8 1/2] net/i40e: queue region set and flush Wei Zhao
2017-10-13 10:06 ` Chilikin, Andrey
2017-10-18 3:00 ` Zhao1, Wei
2017-10-18 13:00 ` Chilikin, Andrey
2017-10-19 2:18 ` Zhao1, Wei
2017-10-11 8:55 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add API for configuration of queue region Wei Zhao
2017-10-11 11:29 ` [dpdk-dev] [PATCH v8 0/2] net/i40e: API to configure queue regions for RSS Peng, Yuan
2017-10-11 21:06 ` Ferruh Yigit
2017-10-13 1:52 ` Zhao1, Wei
2017-08-29 1:46 [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07C61CE2@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).