From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: RE: [PATCH 1/2] config/arm: Do not require processor information
Date: Mon, 17 Apr 2023 07:41:08 +0000 [thread overview]
Message-ID: <AS8PR08MB7080AD01CE5FA6236AE666A59E9C9@AS8PR08MB7080.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230414124139.66443-2-akihiko.odaki@daynix.com>
> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
> Sent: Friday, April 14, 2023 8:42 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Akihiko Odaki <akihiko.odaki@daynix.com>
> Subject: [PATCH 1/2] config/arm: Do not require processor information
>
> DPDK can be built even without exact processor information for x86 and ppc so allow to
> build for Arm even if we don't know the targeted processor is unknown.
Hi Akihiko,
The design idea was to require an explicit generic build.
Default/native build doesn't fall back to generic build when SoC info is not on the list.
So the user has less chance to generate a suboptimal binary by accident.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> config/arm/meson.build | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build index 6442ec9596..724c00ad7e
> 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -582,29 +582,31 @@ if update_flags
> enable_drivers += ',' + soc_config.get('enable_drivers', '')
> endif
>
> - if implementers.has_key(implementer_id)
> + if not implementers.has_key(implementer_id)
> + implementer_id = 'generic'
> + endif
> +
> + implementer_config = implementers[implementer_id]
> + part_number_config = implementer_config['part_number_config']
> +
> + if not part_number_config.has_key(part_number)
> + implementer_id = 'generic'
> +
> + if dpdk_conf.get('RTE_ARCH_32')
> + part_number = 'generic_aarch32'
> + else
> + part_number = 'generic'
> + endif
> +
> implementer_config = implementers[implementer_id]
> - else
> - error('Unsupported Arm implementer: @0@. '.format(implementer_id) +
> - 'Please add support for it or use the generic ' +
> - '(-Dplatform=generic) build.')
> + part_number_config = implementer_config['part_number_config']
> endif
>
> + part_number_config = part_number_config[part_number]
> +
> message('Arm implementer: ' + implementer_config['description'])
> message('Arm part number: ' + part_number)
>
> - part_number_config = implementer_config['part_number_config']
> - if part_number_config.has_key(part_number)
> - # use the specified part_number machine args if found
> - part_number_config = part_number_config[part_number]
> - else
> - # unknown part number
> - error('Unsupported part number @0@ of implementer @1@. '
> - .format(part_number, implementer_id) +
> - 'Please add support for it or use the generic ' +
> - '(-Dplatform=generic) build.')
> - endif
> -
> # add/overwrite flags in the proper order
> dpdk_flags = flags_common + implementer_config['flags'] +
> part_number_config.get('flags', []) + soc_flags
>
> --
> 2.40.0
next prev parent reply other threads:[~2023-04-17 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:41 [PATCH 0/2] Enable generic Arm build Akihiko Odaki
2023-04-14 12:41 ` [PATCH 1/2] config/arm: Do not require processor information Akihiko Odaki
2023-04-17 7:41 ` Ruifeng Wang [this message]
2023-04-20 1:40 ` Akihiko Odaki
2023-04-20 7:10 ` Ruifeng Wang
2023-04-20 7:12 ` Akihiko Odaki
2023-05-04 7:47 ` Akihiko Odaki
2023-05-04 9:43 ` Ruifeng Wang
2023-05-04 15:08 ` Akihiko Odaki
2023-05-29 7:37 ` Juraj Linkeš
2023-04-14 12:41 ` [PATCH 2/2] config/arm: Enable NUMA for generic Arm build Akihiko Odaki
2023-04-20 7:20 ` Ruifeng Wang
2023-04-22 5:26 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB7080AD01CE5FA6236AE666A59E9C9@AS8PR08MB7080.eurprd08.prod.outlook.com \
--to=ruifeng.wang@arm.com \
--cc=akihiko.odaki@daynix.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).