From: "Zhoujian (jay)" <jianjay.zhou@huawei.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Zeng, Xin" <xin.zeng@intel.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"wangxin (U)" <wangxinxin.wang@huawei.com>,
longpeng <longpeng2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices
Date: Fri, 30 Mar 2018 03:02:51 +0000 [thread overview]
Message-ID: <B2D15215269B544CADD246097EACE7473AC1BD8E@DGGEMM505-MBS.china.huawei.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CCC2675@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> Sent: Friday, March 30, 2018 6:28 AM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net; Gonglei
> (Arei) <arei.gonglei@huawei.com>; Zeng, Xin <xin.zeng@intel.com>;
> Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> <wangxinxin.wang@huawei.com>; longpeng <longpeng2@huawei.com>
> Subject: RE: [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices
>
>
>
> > -----Original Message-----
> > From: Jay Zhou [mailto:jianjay.zhou@huawei.com]
> > Sent: Sunday, March 25, 2018 9:34 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Zhang, Roy
> > Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> > arei.gonglei@huawei.com; Zeng, Xin <xin.zeng@intel.com>;
> > weidong.huang@huawei.com; wangxinxin.wang@huawei.com;
> > longpeng2@huawei.com; jianjay.zhou@huawei.com
> > Subject: [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices
>
> Use crypto/virtio: ...
Okay.
>
>
> >
> > The idea comes from QAT and virtio-net devices.
>
> Could you elaborate a bit more here? Which idea?
> Probably better to describe the patch and not compare with other devices.
I'll describe the patch in more details, and it will help to review the code
I think.
>
> >
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---
> > drivers/crypto/virtio/virtio_crypto_capabilities.h | 51 +
> > drivers/crypto/virtio/virtio_cryptodev.c | 1553
> > ++++++++++++++++++++
> > drivers/crypto/virtio/virtio_cryptodev.h | 66 +
> > drivers/crypto/virtio/virtio_rxtx.c | 540 +++++++
> > 4 files changed, 2210 insertions(+)
> > create mode 100644 drivers/crypto/virtio/virtio_crypto_capabilities.h
> > create mode 100644 drivers/crypto/virtio/virtio_cryptodev.c
> > create mode 100644 drivers/crypto/virtio/virtio_cryptodev.h
> > create mode 100644 drivers/crypto/virtio/virtio_rxtx.c
>
> ...
>
> > index 0000000..8affbef
> > --- /dev/null
> > +++ b/drivers/crypto/virtio/virtio_cryptodev.c
>
> ...
>
> +
> > +static int virtio_crypto_sym_pad_cipher_param(
> > + struct virtio_crypto_cipher_session_para *para,
> > + struct rte_crypto_cipher_xform *cipher_xform) {
> > + switch (cipher_xform->algo) {
> > + case RTE_CRYPTO_CIPHER_NULL:
> > + para->algo = VIRTIO_CRYPTO_NO_CIPHER;
> > + break;
> > + case RTE_CRYPTO_CIPHER_3DES_CBC:
> > + para->algo = VIRTIO_CRYPTO_CIPHER_3DES_CBC;
> > + break;
>
> Do you support these algorithms? From capabilities, it looks like you only
> support AES-CBC and SHA1, but from the cover letter, you say that those are
> the ones that you have tested, which means that this PMD actually supports
> more?
Yes, this PMD actually supports more. But for now, it is limited by the
virtio-crypto vhost-crypto backend which only supports AES-CBC and SHA1,
so only AES-CBC and SHA1 can be tested, others are not guaranteed.
I think it's better to remove other cases and algorithms, we can add them
once the virtio-crypto vhost-user backend supports them.
What do you think?
>
>
> > + case RTE_CRYPTO_CIPHER_3DES_CTR:
> > + para->algo = VIRTIO_CRYPTO_CIPHER_3DES_CTR;
> > + break;
>
> ...
>
> > +RTE_PMD_REGISTER_PCI(CRYPTODEV_NAME_VIRTIO_PMD,
> > rte_virtio_crypto_driver);
> > +RTE_PMD_REGISTER_CRYPTO_DRIVER(virtio_crypto_drv,
> > rte_virtio_crypto_driver,
> > + cryptodev_virtio_driver_id);
>
> RTE_PMD_REGISTER_CRYPTO_DRIVER has changed. Could you rebase against dpdk-
> next-crypto?
> You need to pass rte_virtio_crypto_driver.driver as a second parameter.
>
Will do.
Regards,
Jay
next prev parent reply other threads:[~2018-03-30 3:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 8:33 [dpdk-dev] [PATCH v3 0/7] crypto: add virtio poll mode driver Jay Zhou
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions Jay Zhou
2018-03-26 5:16 ` Zhang, Roy Fan
2018-03-29 16:06 ` De Lara Guarch, Pablo
2018-03-30 2:28 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure Jay Zhou
2018-03-26 5:20 ` Zhang, Roy Fan
2018-03-29 22:12 ` De Lara Guarch, Pablo
2018-03-30 2:43 ` Zhoujian (jay)
2018-03-30 7:38 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-29 22:28 ` De Lara Guarch, Pablo
2018-03-30 3:02 ` Zhoujian (jay) [this message]
2018-03-30 7:39 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 4/7] crypto/virtio: add makefile Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:36 ` De Lara Guarch, Pablo
2018-03-30 6:36 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 6/7] cryptodev: add function tests " Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:31 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer Jay Zhou
2018-03-26 8:04 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2D15215269B544CADD246097EACE7473AC1BD8E@DGGEMM505-MBS.china.huawei.com \
--to=jianjay.zhou@huawei.com \
--cc=arei.gonglei@huawei.com \
--cc=dev@dpdk.org \
--cc=longpeng2@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).