From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jay Zhou <jianjay.zhou@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"arei.gonglei@huawei.com" <arei.gonglei@huawei.com>,
"Zeng, Xin" <xin.zeng@intel.com>,
"weidong.huang@huawei.com" <weidong.huang@huawei.com>,
"wangxinxin.wang@huawei.com" <wangxinxin.wang@huawei.com>,
"longpeng2@huawei.com" <longpeng2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions
Date: Thu, 29 Mar 2018 16:06:55 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCC1F49@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <f0a54627c1cc2dd189ba1224458540bb752da130.1521964379.git.jianjay.zhou@huawei.com>
Hi Jay,
> -----Original Message-----
> From: Jay Zhou [mailto:jianjay.zhou@huawei.com]
> Sent: Sunday, March 25, 2018 9:34 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Zhang, Roy
> Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> arei.gonglei@huawei.com; Zeng, Xin <xin.zeng@intel.com>;
> weidong.huang@huawei.com; wangxinxin.wang@huawei.com;
> longpeng2@huawei.com; jianjay.zhou@huawei.com
> Subject: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental
> functions
>
> Since there does not have the common virtio library, we have to put these
> files here. They are basically the same with virtio net related files with some
> minor changes.
>
> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
> config/common_base | 20 ++
> drivers/crypto/virtio/virtio_logs.h | 47 ++++
> drivers/crypto/virtio/virtio_pci.c | 460
> ++++++++++++++++++++++++++++++++++++
> drivers/crypto/virtio/virtio_pci.h | 253 ++++++++++++++++++++
> drivers/crypto/virtio/virtio_ring.h | 137 +++++++++++
> drivers/crypto/virtio/virtqueue.c | 43 ++++
> drivers/crypto/virtio/virtqueue.h | 176 ++++++++++++++
> 7 files changed, 1136 insertions(+)
> create mode 100644 drivers/crypto/virtio/virtio_logs.h
> create mode 100644 drivers/crypto/virtio/virtio_pci.c
> create mode 100644 drivers/crypto/virtio/virtio_pci.h
> create mode 100644 drivers/crypto/virtio/virtio_ring.h
> create mode 100644 drivers/crypto/virtio/virtqueue.c create mode
> 100644 drivers/crypto/virtio/virtqueue.h
>
> diff --git a/config/common_base b/config/common_base index
> ad03cf4..19d0cdd 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -482,6 +482,26 @@
> CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=n
> CONFIG_RTE_QAT_PMD_MAX_NB_SESSIONS=2048
>
> #
> +# Compile PMD for virtio crypto devices #
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_INIT=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_SESSION=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DRIVER=n
> +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DUMP=n
Could you remove these DEBUG options? I see that they are used only for enabling logging.
For that, we are using now dynamic logging.
Take a look at the following commit, as an example:
510ac6f4f030 ("event/sw: support dynamic logging")
Pablo
next prev parent reply other threads:[~2018-03-29 16:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 8:33 [dpdk-dev] [PATCH v3 0/7] crypto: add virtio poll mode driver Jay Zhou
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions Jay Zhou
2018-03-26 5:16 ` Zhang, Roy Fan
2018-03-29 16:06 ` De Lara Guarch, Pablo [this message]
2018-03-30 2:28 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure Jay Zhou
2018-03-26 5:20 ` Zhang, Roy Fan
2018-03-29 22:12 ` De Lara Guarch, Pablo
2018-03-30 2:43 ` Zhoujian (jay)
2018-03-30 7:38 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-29 22:28 ` De Lara Guarch, Pablo
2018-03-30 3:02 ` Zhoujian (jay)
2018-03-30 7:39 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 4/7] crypto/virtio: add makefile Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:36 ` De Lara Guarch, Pablo
2018-03-30 6:36 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 6/7] cryptodev: add function tests " Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:31 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer Jay Zhou
2018-03-26 8:04 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCC1F49@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=arei.gonglei@huawei.com \
--cc=dev@dpdk.org \
--cc=jianjay.zhou@huawei.com \
--cc=longpeng2@huawei.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).