DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet
Date: Fri, 15 Sep 2017 12:29:44 +0000	[thread overview]
Message-ID: <BN6PR12MB1122C0D5B3438AFBBAB5CC68AE6C0@BN6PR12MB1122.namprd12.prod.outlook.com> (raw)
In-Reply-To: <e5a52273-5b8c-1789-8611-82a16f29777a@intel.com>

>On 9/13/2017 6:47 PM, Ravi Kumar wrote:
>> Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>
><...>
>
>> +#
>> +# Export include files
>> +#
>> +SYMLINK-y-include += axgbe_ethdev.h
>> +SYMLINK-y-include += axgbe_rxtx.h
>> +SYMLINK-y-include += axgbe_common.h
>> +SYMLINK-y-include += axgbe_phy.h
>
>Are these need to be public header? If not just delete above lines.

Thanks a lot for all the review comments Ferruh. We are working to address your comments on all our patches. 

Regards,
Ravi
>> +
>> +# this lib depends upon:
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_eal
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_mbuf
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_mempool
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_ether
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_AXGBE_PMD) += lib/librte_kvargs
>
>No more required, above drivers/net/Makefile update already does the work, this can be removed.
>
><...>
>
>> +#define min_t(type, x, y) ({                    \
>> +	type __min1 = (x);                      \
>> +	type __min2 = (y);                      \
>> +	__min1 < __min2 ? __min1 : __min2; })
>> +
>> +#define max_t(type, x, y) ({                    \
>> +	type __max1 = (x);                      \
>> +	type __max2 = (y);                      \
>> +	__max1 > __max2 ? __max1 : __max2; })
>
>You can use RTE_MIN, RTE_MAX
>
>> +
>> +#define AXGBE_REG_WRITE(val, reg) do { \
>> +	(*((volatile uint32_t *) (reg))) = val; \ } while (0)
>> +
>> +static inline uint32_t ioread32(uint64_t addr) {
>
>You can use rte equvalent functions, rte_read32 or rte_read32_relaxed please check rte_io.h
>
><...>
>
>> +	pci_dev = RTE_DEV_TO_PCI(eth_dev->device);
>> +	pdata->pci_dev = pci_dev;
>> +	rte_eth_copy_pci_info(eth_dev, pci_dev);
>
>This should be already done by rte_eth_dev_pci_generic_probe()
>
><...>

  reply	other threads:[~2017-09-15 12:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 17:47 [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK Ravi Kumar
2017-09-13 17:47 ` [dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet Ravi Kumar
2017-09-14 16:25   ` Ferruh Yigit
2017-09-15 12:29     ` Kumar, Ravi1 [this message]
2017-09-13 17:47 ` [dpdk-dev] [PATCH 3/4] doc: Add documents " Ravi Kumar
2017-09-14 11:57   ` Hemant Agrawal
2017-09-14 14:02     ` Kumar, Ravi1
2017-09-15  4:41       ` Hemant Agrawal
2017-09-15 12:26         ` Kumar, Ravi1
2017-11-13 19:20           ` Thomas Monjalon
2017-11-14  6:36             ` Kumar, Ravi1
     [not found]               ` <DM2PR12MB0138AA6F2C7782A949E2521C9D280@DM2PR12MB0138.namprd12.prod.outlook.com>
2017-11-15  0:07                 ` Hemant Agrawal
2017-11-17 17:48                   ` Shippen, Greg
2017-11-19 16:09                     ` Hemant Agrawal
2017-09-14 16:26   ` Ferruh Yigit
2017-09-18 17:39   ` Mcnamara, John
2017-09-13 17:47 ` [dpdk-dev] [PATCH 4/4] maintainers: add maintainer for AMD AXGBE PMD Ravi Kumar
2017-09-14 16:26   ` Ferruh Yigit
2017-09-14  8:53 ` [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK Ferruh Yigit
2017-09-14  9:48   ` Kumar, Ravi1
2017-09-14 16:25     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR12MB1122C0D5B3438AFBBAB5CC68AE6C0@BN6PR12MB1122.namprd12.prod.outlook.com \
    --to=ravi1.kumar@amd.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).