From: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: add HIGIG2 key field to flow API
Date: Wed, 16 Oct 2019 03:14:48 +0000 [thread overview]
Message-ID: <BYAPR18MB2392017537296BED3FD1A9C6AC920@BYAPR18MB2392.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20191015094717.052d0993@hermes.lan>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 15, 2019 10:17 PM
> To: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic <marko.kovacevic@intel.com>;
> Thomas Monjalon <thomas@monjalon.net>; Ferruh Yigit
> <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>;
> dev@dpdk.org; ajit.khaparde@broadcom.com
> Subject: [EXT] Re: [dpdk-dev] [PATCH] ethdev: add HIGIG2 key field to flow API
>
> External Email
>
> ----------------------------------------------------------------------
> On Mon, 14 Oct 2019 09:59:56 +0530
> <kirankumark@marvell.com> wrote:
>
> > +/**
> > + * RTE_FLOW_ITEM_TYPE_HIGIG2
> > + * Matches higig2 header.
> > + */
> > +struct rte_higig2_frc {
> > + uint32_t ksop:8;
> > + uint32_t resv:3;
> > + uint32_t mcst:1;
> > + uint32_t tc:4;
> > + uint32_t dst_modid:8;
> > + uint32_t dst_pid:8;
> > + uint32_t src_modid:8;
> > + uint32_t src_pid:8;
> > + uint32_t lbid:8;
> > + uint32_t dp:2;
> > + uint32_t resv1:3;
> > + uint32_t ppd_type:3;
> > +} __attribute__((packed));
> > +
> > +struct rte_higig2_ppt_type0 {
> > + uint32_t dst_t:1;
> > + uint32_t dst_tgid:3;
> > + uint32_t ingress_tagged:1;
> > + uint32_t mirror_only:1;
> > + uint32_t mirror_done:1;
> > + uint32_t mirror:1;
> > + uint32_t res:2;
> > + uint32_t l3:1;
> > + uint32_t label_present:1;
> > + uint32_t vc_label2:4;
> > + uint32_t vc_label1:8;
> > + uint32_t vc_label0:8;
> > + uint32_t vid_high:8;
> > + uint32_t vid_low:8;
> > + uint32_t pfm:2;
> > + uint32_t src_t:1;
> > + uint32_t res1:2;
> > + uint32_t opcode:3;
> > + uint32_t hdr_ext_len:3;
> > + uint32_t res2:5;
> > +} __attribute__((packed));
> > +
> > +struct rte_higig2_ppt_type1 {
> > + uint32_t classification:16;
> > + uint32_t resv:16;
> > + uint32_t vid:16;
> > + uint32_t pfm:2;
> > + uint32_t src_t:1;
> > + uint32_t resv1:2;
> > + uint32_t opcode:3;
> > + uint32_t hdr_ext_len:3;
> > + uint32_t resv2:5;
> > +} __attribute__((packed));
> > +
> > +RTE_STD_C11
> > +struct rte_flow_item_higig2_hdr {
> > + struct rte_higig2_frc fcr;
> > + union {
> > + struct rte_higig2_ppt_type0 ppt0;
> > + struct rte_higig2_ppt_type1 ppt1;
> > + };
> > +} __attribute__((packed));
> > +
> > +/** Default mask for RTE_FLOW_ITEM_TYPE_HIGIG2. */ #ifndef
> > +__cplusplus static const struct rte_flow_item_higig2_hdr
> > +rte_flow_item_higig2_hdr_mask = {
> > + .ppt1.classification = 0xffff,
> > + .ppt1.vid = 0xfff,
> > +};
> > +#endif
> > +
>
> Why do all these structures have to be packed. They are all uint32.
Will fix in V4.
prev parent reply other threads:[~2019-10-16 3:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 4:29 [dpdk-dev] " kirankumark
2019-10-14 7:08 ` Andrew Rybchenko
2019-10-15 4:23 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-15 6:20 ` [dpdk-dev] " kirankumark
2019-10-15 6:27 ` Jerin Jacob
2019-10-15 6:57 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-15 8:22 ` [dpdk-dev] " Ananyev, Konstantin
2019-10-15 8:32 ` [dpdk-dev] [PATCH v3] " kirankumark
2019-10-17 4:15 ` [dpdk-dev] [PATCH v4] " kirankumark
2019-10-17 9:08 ` Andrew Rybchenko
2019-10-18 4:13 ` [dpdk-dev] [PATCH v5] " kirankumark
2019-10-18 7:36 ` Andrew Rybchenko
2019-10-18 17:36 ` Ferruh Yigit
2019-10-19 4:51 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-19 4:56 ` [dpdk-dev] [PATCH v6] " kirankumark
2019-10-19 9:47 ` Jerin Jacob
2019-10-20 4:52 ` [dpdk-dev] [PATCH v7] " kirankumark
2019-10-20 13:56 ` Jerin Jacob
2019-10-21 3:52 ` [dpdk-dev] [PATCH v8] " kirankumark
2019-10-21 9:16 ` [dpdk-dev] [PATCH v9] " kirankumark
2019-10-21 16:48 ` Olivier Matz
2019-10-22 4:16 ` [dpdk-dev] [PATCH v10] " kirankumark
2019-10-22 9:19 ` Ferruh Yigit
2019-10-23 10:50 ` Raslan Darawsheh
2019-10-23 11:39 ` Olivier Matz
2019-10-23 11:43 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2019-10-23 14:04 ` Olivier Matz
2019-10-23 14:14 ` Ferruh Yigit
2019-10-23 22:04 ` [dpdk-dev] " Thomas Monjalon
2019-10-15 16:47 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2019-10-16 3:14 ` Kiran Kumar Kokkilagadda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2392017537296BED3FD1A9C6AC920@BYAPR18MB2392.namprd18.prod.outlook.com \
--to=kirankumark@marvell.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).