From: Alex Rosenbaum <rosenbaumalex@gmail.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: DPDK <dev@dpdk.org>, "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [RFC v2 1/5] ether: add flow action to redirect packet in a switch domain
Date: Sat, 23 Dec 2017 00:10:08 +0200 [thread overview]
Message-ID: <CAFgAxU9rLrFRamL5E5rkZ-HrsuyxGg=zC6HCWoh35Ri8hY0YQA@mail.gmail.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061153123F75@SHSMSX103.ccr.corp.intel.com>
+Adrien
On Fri, Dec 22, 2017 at 10:20 AM, Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
>> On Thu, Dec 21, 2017 at 4:35 AM, Qi Zhang <qi.z.zhang@intel.com> wrote:
>> > Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to
>> > redirect
>> A verbs would be better suited for an ACTION_TYPE. while ".._TYPE_PORT" is
>> a nous.
>> Probably ".._TYPE_REDIRECT" would better fit here.
>
> I agree it will be better to use verbs for action, so we can have TYPE_REDIRECT_TO_PORT/VF/PF...,
> But since we already have ACTION_TYPE_VF, ACTION_TYPE_PF ...
> Maybe it's better just to follow the same pattern?
hemmm, missed these ACTION_TYPE_VF/PF...
Adrien, what do you think about these naming conventions?
next prev parent reply other threads:[~2017-12-22 22:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 2:35 [dpdk-dev] [RFC v2 0/5] rte_flow extension for vSwitch acceleration Qi Zhang
2017-12-21 2:35 ` [dpdk-dev] [RFC v2 1/5] ether: add flow action to redirect packet in a switch domain Qi Zhang
2017-12-21 12:37 ` Alex Rosenbaum
2017-12-22 8:20 ` Zhang, Qi Z
2017-12-22 22:10 ` Alex Rosenbaum [this message]
2017-12-21 2:35 ` [dpdk-dev] [RFC v2 2/5] ether: add flow last hit query support Qi Zhang
2017-12-21 2:35 ` [dpdk-dev] [RFC v2 3/5] ether: Add flow timeout support Qi Zhang
2017-12-21 13:59 ` Alex Rosenbaum
2017-12-22 9:03 ` Zhang, Qi Z
2017-12-22 14:06 ` Wiles, Keith
2018-01-14 2:03 ` Zhang, Qi Z
2017-12-22 22:26 ` Alex Rosenbaum
2017-12-26 3:28 ` Zhang, Qi Z
2017-12-26 7:44 ` Alex Rosenbaum
2017-12-21 2:35 ` [dpdk-dev] [RFC v2 4/5] ether: add more protocol support in rte_flow Qi Zhang
2017-12-21 2:35 ` [dpdk-dev] [RFC v2 5/5] ether: add packet modification aciton " Qi Zhang
2017-12-21 13:01 ` [dpdk-dev] [RFC v2 0/5] rte_flow extension for vSwitch acceleration Alex Rosenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFgAxU9rLrFRamL5E5rkZ-HrsuyxGg=zC6HCWoh35Ri8hY0YQA@mail.gmail.com' \
--to=rosenbaumalex@gmail.com \
--cc=adrien.mazarguil@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).