From: Dan Gora <dg@adax.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration
Date: Wed, 20 Jun 2018 10:07:28 -0700 [thread overview]
Message-ID: <CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com> (raw)
In-Reply-To: <CAGyogRaDw0mLLY+3w9_7JqAF3E2cHDfKOUkiFgXbtkHMDdahBA@mail.gmail.com>
Hi Ferruh,
The documentation for rte_eth_dev_configure() should get updated as
well to document this requirement to strip the unsupported RSS hash
function bits. The current documentation only refers to the tx/rx
offload bits:
* - Any offloading set in eth_conf->[rt]xmode.offloads must be within
* the [rt]x_offload_capa returned from rte_eth_dev_infos_get().
* Any type of device supported offloading set in the input argument
* eth_conf->[rt]xmode.offloads to rte_eth_dev_configure() is enabled
* on all queues and it can't be disabled in rte_eth_[rt]x_queue_setup().
thanks
dan
On Wed, Jun 20, 2018 at 10:03 AM, Dan Gora <dg@adax.com> wrote:
> Hi Ferruh,
>
> Thanks for this.. I had started working on a patch to do this as well
> because I got bit by this error.
>
> Shouldn't all of the example applications also add the code to strip
> the unsupported Tx and Rx offload bits as well? It would help new
> users (like me!) to understand that this is a requirement for all
> callers of rte_eth_dev_configure().
>
> rte_eth_dev_info_get(port_id, &dev_info);
>
> /* Only set the offload bits which are actually supported */
> port_conf.txmode.offloads &= dev_info.tx_offload_capa;
> port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
>
> thanks
> dan
next prev parent reply other threads:[~2018-06-20 17:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:01 Ferruh Yigit
2018-06-20 15:11 ` Hunt, David
2018-06-20 17:03 ` Dan Gora
2018-06-20 17:07 ` Dan Gora [this message]
2018-06-20 17:15 ` Ferruh Yigit
2018-06-28 23:55 ` Thomas Monjalon
2018-06-29 12:54 ` Ferruh Yigit
2018-06-20 17:15 ` Ferruh Yigit
2018-06-21 16:54 ` Pavan Nikhilesh
2018-06-21 17:16 ` Ferruh Yigit
2018-06-26 17:32 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-06-29 13:54 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-07-03 16:58 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-07-03 18:08 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2018-07-04 20:02 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2018-07-05 8:17 ` Zhao, MeijuanX
2018-07-05 9:30 ` Hunt, David
2018-07-05 13:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGyogRZD1L5EWNd8EsNGuapGq+U=_BiiE-xt=rNuuA7Nd8GPdA@mail.gmail.com' \
--to=dg@adax.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).