From: Dan Gora <dg@adax.com>
To: "Hunt, David" <david.hunt@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Remy Horton <remy.horton@intel.com>,
Ori Kam <orika@mellanox.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Jijiang Liu <jijiang.liu@intel.com>,
dev@dpdk.org, Liang Ma <liang.j.ma@intel.com>,
Xueming Li <xuemingl@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration
Date: Wed, 20 Jun 2018 10:03:40 -0700 [thread overview]
Message-ID: <CAGyogRaDw0mLLY+3w9_7JqAF3E2cHDfKOUkiFgXbtkHMDdahBA@mail.gmail.com> (raw)
In-Reply-To: <d00e6b84-ac5a-dae0-fba6-5f40d0bf69b2@intel.com>
Hi Ferruh,
Thanks for this.. I had started working on a patch to do this as well
because I got bit by this error.
Shouldn't all of the example applications also add the code to strip
the unsupported Tx and Rx offload bits as well? It would help new
users (like me!) to understand that this is a requirement for all
callers of rte_eth_dev_configure().
rte_eth_dev_info_get(port_id, &dev_info);
/* Only set the offload bits which are actually supported */
port_conf.txmode.offloads &= dev_info.tx_offload_capa;
port_conf.rxmode.offloads &= dev_info.rx_offload_capa;
thanks
dan
On Wed, Jun 20, 2018 at 8:11 AM, Hunt, David <david.hunt@intel.com> wrote:
> Hi Ferruh,
> On 20/6/2018 4:01 PM, Ferruh Yigit wrote:
>>
>> ethdev layer introduced checks for application requested RSS hash
>> functions and returns error for ones unsupported by hardware
>>
>> This check breaks some sample applications which blindly configures
>> RSS hash functions without checking underlying hardware support.
>>
>> Updated examples to mask out unsupported RSS has functions during device
>> configuration.
>> Prints a log if configuration values updated by this check.
>>
>> Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Return error added in this release, so no need to backport the fix to
>> previous versions.
>>
>> Cc: David Hunt <david.hunt@intel.com>
>> Cc: Liang Ma <liang.j.ma@intel.com>
>> Cc: Xueming Li <xuemingl@mellanox.com>
next prev parent reply other threads:[~2018-06-20 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 15:01 Ferruh Yigit
2018-06-20 15:11 ` Hunt, David
2018-06-20 17:03 ` Dan Gora [this message]
2018-06-20 17:07 ` Dan Gora
2018-06-20 17:15 ` Ferruh Yigit
2018-06-28 23:55 ` Thomas Monjalon
2018-06-29 12:54 ` Ferruh Yigit
2018-06-20 17:15 ` Ferruh Yigit
2018-06-21 16:54 ` Pavan Nikhilesh
2018-06-21 17:16 ` Ferruh Yigit
2018-06-26 17:32 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-06-29 13:54 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-07-03 16:58 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-07-03 18:08 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2018-07-04 20:02 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2018-07-05 8:17 ` Zhao, MeijuanX
2018-07-05 9:30 ` Hunt, David
2018-07-05 13:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGyogRaDw0mLLY+3w9_7JqAF3E2cHDfKOUkiFgXbtkHMDdahBA@mail.gmail.com \
--to=dg@adax.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jijiang.liu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=liang.j.ma@intel.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=remy.horton@intel.com \
--cc=tomasz.kantecki@intel.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).