From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Thomas Monjalon" <thomas@monjalon.net>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Ray Kinsella" <mdr@ashroe.eu>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
"Narcisa Ana Maria Vasile" <navasile@linux.microsoft.com>,
"Dmitry Malloy" <dmitrym@microsoft.com>,
"Pallavi Kadam" <pallavi.kadam@intel.com>
Subject: Re: [PATCH v3 2/2] eal: factorize lcore main loop
Date: Thu, 14 Apr 2022 13:48:14 +0200 [thread overview]
Message-ID: <CAJFAV8x5s2ddc1rVUQqPQgDQW56PpnGJmSWnVMEy-213y=q=PQ@mail.gmail.com> (raw)
In-Reply-To: <20220405163448.2099-2-david.marchand@redhat.com>
On Tue, Apr 5, 2022 at 6:37 PM David Marchand <david.marchand@redhat.com> wrote:
>
> All OS implementations provide the same main loop.
> Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation
> between main and threads and factorize the rest as common code.
> Thread id are now logged as string in a common format across OS.
>
> Note: libabigail flags this change as breaking ABI in clang builds:
>
> 1 function with some indirect sub-type change:
>
> [C] 'function int rte_eal_remote_launch(int (void*)*, void*, unsigned
> int)' at eal_common_launch.c:35:1 has some indirect sub-type
> changes:
> parameter 1 of type 'int (void*)*' changed:
> in pointed to type 'function type int (void*)' at rte_launch.h:31:1:
> entity changed from 'function type int (void*)' to 'typedef
> lcore_function_t' at rte_launch.h:31:1
> type size hasn't changed
>
> This is being investigated on libabigail side.
> For now, we don't have much choice but to waive reports on this symbol.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Added a note in the commitlog about Windows EAL threads affinity (from
a parallel discussion with Tyler), and applied.
Thanks.
--
David Marchand
prev parent reply other threads:[~2022-04-14 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:30 [PATCH] " David Marchand
2022-03-23 12:01 ` Morten Brørup
2022-03-24 8:31 ` Tyler Retzlaff
2022-03-24 14:44 ` David Marchand
2022-03-25 12:11 ` Tyler Retzlaff
2022-03-25 14:58 ` Thomas Monjalon
2022-03-25 15:09 ` David Marchand
2022-03-25 16:38 ` Tyler Retzlaff
2022-03-25 12:23 ` Tyler Retzlaff
2022-04-01 8:44 ` [PATCH v2 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-01 8:44 ` [PATCH v2 2/2] eal: factorize lcore main loop David Marchand
2022-04-05 7:05 ` David Marchand
2022-04-05 16:34 ` [PATCH v3 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-05 16:34 ` [PATCH v3 2/2] eal: factorize lcore main loop David Marchand
2022-04-14 11:48 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x5s2ddc1rVUQqPQgDQW56PpnGJmSWnVMEy-213y=q=PQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=mb@smartsharesystems.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).