From: David Marchand <david.marchand@redhat.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Neil Horman <nhorman@tuxdriver.com>, dev <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v4] build: enable allow experimental API flag
Date: Fri, 10 Apr 2020 14:12:26 +0200 [thread overview]
Message-ID: <CAJFAV8y8p987iM=PST0JOsGkfXFhcUXN6DSvtMqnBXDZ++hXdw@mail.gmail.com> (raw)
In-Reply-To: <20200410090314.691-1-pbhagavatula@marvell.com>
On Fri, Apr 10, 2020 at 11:04 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and
> meson.build instead enable ALLOW_EXPERIMENTAL_API flag across app, lib and
> drivers.
> This changes reduces the clutter across the project while still maintaining
> the functionality of ALLOW_EXPERIMENTAL_API i.e. warning external
> applications about experimental API usage.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Little conflict on app/test-fib/Makefile that git-am handles fine (but
Intel CI had trouble with).
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 351d29cb6..013e86715 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -393,7 +393,7 @@ dpdk_test = executable('dpdk-test',
> test_sources,
> link_whole: link_libs,
> dependencies: test_dep_objs,
> - c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
> + c_args: [cflags, default_cflags],
> install_rpath: driver_install_path,
> install: true)
>
That would pass the flags twice.
I will fix when applying as:
+ c_args: cflags,
> diff --git a/drivers/mempool/octeontx2/Makefile b/drivers/mempool/octeontx2/Makefile
> index 337babf66..6af7b5432 100644
> --- a/drivers/mempool/octeontx2/Makefile
> +++ b/drivers/mempool/octeontx2/Makefile
> @@ -32,7 +30,7 @@ EXPORT_MAP := rte_mempool_octeontx2_version.map
> #
> SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += \
> otx2_mempool_ops.c \
> - otx2_mempool.c \
> + otx2_mempool.c \
> otx2_mempool_irq.c \
> otx2_mempool_debug.c
>
> diff --git a/drivers/net/hinic/base/meson.build b/drivers/net/hinic/base/meson.build
> index 6cf947f84..0695994ba 100644
> --- a/drivers/net/hinic/base/meson.build
> +++ b/drivers/net/hinic/base/meson.build
> @@ -12,7 +12,7 @@ sources = [
> 'hinic_pmd_niccfg.c',
> 'hinic_pmd_nicio.c',
> 'hinic_pmd_wq.c',
> - 'hinic_pmd_mbox.c',
> + 'hinic_pmd_mbox.c',
> ]
>
> extra_flags = []
> diff --git a/drivers/net/hinic/meson.build b/drivers/net/hinic/meson.build
> index bc7e24639..34ec4af66 100644
> --- a/drivers/net/hinic/meson.build
> +++ b/drivers/net/hinic/meson.build
> @@ -8,7 +8,7 @@ sources = files(
> 'hinic_pmd_ethdev.c',
> 'hinic_pmd_rx.c',
> 'hinic_pmd_tx.c',
> - 'hinic_pmd_flow.c',
> + 'hinic_pmd_flow.c',
> )
>
> includes += include_directories('base')
> diff --git a/lib/librte_gso/meson.build b/lib/librte_gso/meson.build
> index ad8dd8583..af3a63381 100644
> --- a/lib/librte_gso/meson.build
> +++ b/lib/librte_gso/meson.build
> @@ -2,6 +2,6 @@
> # Copyright(c) 2017 Intel Corporation
>
> sources = files('gso_common.c', 'gso_tcp4.c', 'gso_udp4.c',
> - 'gso_tunnel_tcp4.c', 'rte_gso.c')
> + 'gso_tunnel_tcp4.c', 'rte_gso.c')
> headers = files('rte_gso.h')
> deps += ['ethdev']
Whitespace damage, will remove those hunks when applying.
Reviewed-by: David Marchand <david.marchand@redhat.com>
Thanks.
--
David Marchand
next prev parent reply other threads:[~2020-04-10 12:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 18:32 [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global Jerin Jacob
2020-04-02 18:32 ` [dpdk-dev] [PATCH v2 2/2] build: makefile " Jerin Jacob
2020-04-03 7:23 ` [dpdk-dev] [PATCH v2 1/2] build: meson " David Marchand
2020-04-03 7:45 ` David Marchand
2020-04-03 8:05 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2020-04-03 8:18 ` David Marchand
2020-04-03 9:10 ` Bruce Richardson
2020-04-03 9:14 ` David Marchand
2020-04-03 9:35 ` Bruce Richardson
2020-04-03 10:56 ` Thomas Monjalon
2020-04-03 11:02 ` Pavan Nikhilesh Bhagavatula
2020-04-03 10:20 ` [dpdk-dev] " Hemant Agrawal (OSS)
2020-04-03 14:19 ` [dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally pbhagavatula
2020-04-06 20:16 ` David Marchand
2020-04-10 9:03 ` [dpdk-dev] [PATCH v4] build: enable allow experimental API flag pbhagavatula
2020-04-10 12:12 ` David Marchand [this message]
2020-04-10 15:48 ` David Marchand
2020-04-13 14:55 ` [dpdk-dev] [PATCH v5] build: disable experimental API check internally David Marchand
2020-04-14 14:23 ` David Marchand
2020-04-17 10:21 ` Trahe, Fiona
2020-04-17 13:23 ` David Marchand
2020-04-17 13:44 ` Trahe, Fiona
2020-04-17 13:54 ` Thomas Monjalon
2020-04-17 13:56 ` David Marchand
2020-04-17 15:05 ` Trahe, Fiona
2020-04-17 15:52 ` Trahe, Fiona
2020-04-18 19:43 ` Chautru, Nicolas
2020-04-19 7:35 ` David Marchand
2020-04-19 16:17 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y8p987iM=PST0JOsGkfXFhcUXN6DSvtMqnBXDZ++hXdw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).