From: Jerin Jacob <jerinjacobk@gmail.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"vfialko@marvell.com" <vfialko@marvell.com>
Subject: Re: [PATCH v3 5/5] eventdev/crypto: fix failed events
Date: Thu, 12 Jan 2023 18:29:49 +0530 [thread overview]
Message-ID: <CALBAE1NUaTH3wJw3Pj74EqU4Cn7aNaM3oHnJOPAAasp-6zB+0Q@mail.gmail.com> (raw)
In-Reply-To: <PH0PR11MB5832CDB080F7E0225A91998CE81A9@PH0PR11MB5832.namprd11.prod.outlook.com>
On Wed, Dec 7, 2022 at 12:26 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
>
> > -----Original Message-----
> > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > Sent: Wednesday, December 7, 2022 12:20 PM
> > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V
> > <s.v.naga.harish.k@intel.com>; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>
> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; vfialko@marvell.com
> > Subject: [PATCH v3 5/5] eventdev/crypto: fix failed events
> >
> > Circular buffer stores events failed to enqueue to eventdev for retrying later.
> > Current implementation adds the same crypto op to circular buffer instead of
> > pointing all the ops in a batch.
> >
> > This fix updates the pointer to pointing to correct ops in the batch.
> >
> > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
> >
> > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Updated the git commit as follows and series applied to
dpdk-next-net-eventdev/for-main. Thanks
ommit 948973d20dbd465f8fcc502f9e3af3b0de3db1e6 (HEAD -> for-main)
Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
Date: Wed Dec 7 00:49:45 2022 -0600
eventdev/crypto: fix failed events
Circular buffer stores events failed to enqueue to eventdev for
retrying later. Current implementation adds the same crypto op
to circular buffer instead of pointing all the ops in a batch.
This fix updates the pointer to pointing to correct ops in the batch.
Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Cc: stable@dpdk.org
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
commit 32fb46e8e37e4cd6f965c9e577243693b99c02d4
Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
Date: Wed Dec 7 00:49:44 2022 -0600
eventdev/crypto: fix overflow in circular buffer
In case of crypto enqueue failures, even though back pressure
flag is set to stop further dequeue from eventdev, the current
logic does not stop dequeueing events for max_nb events.
This is fixed by checking the back pressure just before
dequeuing events from event device.
Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Cc: stable@dpdk.org
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
commit 74bf35c7b2510e9d3da409607a13b5887ceeb590
Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
Date: Wed Dec 7 00:49:43 2022 -0600
eventdev/crypto: fix wrong offset used while flushing events
Events enqueued to eventdev from the beginning of the circular buffer.
This leads to invalid or already freed events getting enqueued to eventdev
from the circular buffer.
Fixed by enqueuing the events to eventdev from the head pointer of
circular buffer.
Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Cc: stable@dpdk.org
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
commit 1597b6602c3d90887c2ec65031377c2dba0aacf1
Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
Date: Wed Dec 7 00:49:42 2022 -0600
eventdev/crypto: fix wrong crypto enqueue count stats
crypto_enq_count is updated on failure to enqueue ops to cryptodev.
Updated crypto_enq_count on successful enqueue of ops to cryptodev.
Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
Cc: stable@dpdk.org
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
commit 2b3049e5e61cff02488e402358854ae5e9b0279d
Author: Ganapati Kundapura <ganapati.kundapura@intel.com>
Date: Wed Dec 7 00:49:41 2022 -0600
eventdev/crypto: select enqueue mode based on implicit release capability
In the current implementation adapter queries event device's capability for
implicit release support.
This information is used to decide whether events are enqueued back as
NEW or FWD events.
This patch updates the adapter to query the port caps for implicit release
to decide on events enqueuing back as NEW/FWD events.
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > ---
> > v3:
> > * Updated commit message
> >
> > v2:
> > * Updated subject line commit message
> >
> > diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> > b/lib/eventdev/rte_event_crypto_adapter.c
> > index 31b8255..5d962a1 100644
> > --- a/lib/eventdev/rte_event_crypto_adapter.c
> > +++ b/lib/eventdev/rte_event_crypto_adapter.c
> > @@ -753,7 +753,7 @@ eca_crypto_adapter_deq_run(struct
> > event_crypto_adapter *adapter,
> > for (i = nb_enqueued; i < n; i++)
> > eca_circular_buffer_add(
> > &adapter->ebuf,
> > - ops[nb_enqueued]);
> > + ops[i]);
> >
> > check:
> > nb_deq += n;
> > --
> > 2.6.4
>
next prev parent reply other threads:[~2023-01-12 13:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:10 [PATCH v1 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Ganapati Kundapura
2022-12-01 6:07 ` Naga Harish K, S V
2022-12-01 6:56 ` Kundapura, Ganapati
2022-11-30 17:10 ` [PATCH v1 3/5] eventdev/crypto: wrong offset used while flushing events Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 4/5] eventdev/crypto: overflow in circular buffer Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-05 11:34 ` [EXT] " Volodymyr Fialko
2022-12-07 5:40 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-05 11:35 ` [EXT] " Volodymyr Fialko
2022-12-06 16:17 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:25 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-01 6:46 ` [PATCH v2 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:37 ` Gujjar, Abhinandan S
2022-12-01 13:20 ` [EXT] [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Volodymyr Fialko
2022-12-06 15:44 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-07 6:49 ` [PATCH v3 " Ganapati Kundapura
2022-12-07 6:49 ` [PATCH v3 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-07 7:04 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 5/5] eventdev/crypto: fix failed events Ganapati Kundapura
2022-12-07 6:56 ` Gujjar, Abhinandan S
2023-01-12 12:59 ` Jerin Jacob [this message]
2022-12-07 6:54 ` [PATCH v3 1/5] eventdev/event_crypto: process event port's impl rel cap Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NUaTH3wJw3Pj74EqU4Cn7aNaM3oHnJOPAAasp-6zB+0Q@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).