From: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"alvinx.zhang@intel.com" <alvinx.zhang@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>,
"Su, Simei" <simei.su@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: RE: [PATCH v4] net/igc: add support for secondary processes
Date: Fri, 1 Jul 2022 03:13:15 +0000 [thread overview]
Message-ID: <CO6PR11MB5602142F983156BBAF7D2DF4F1BD9@CO6PR11MB5602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM4PR11MB599484ACAD188A530C44BBCDD7BA9@DM4PR11MB5994.namprd11.prod.outlook.com>
>> The RX function was not specified in the secondary process, causing
>> the secondary process to segfault in a multi-process environment.
>>
>> This patch specify RX/TX functions in "dev_init" to support secondary processes.
>>
>> Fixes: 66fde1b943eb ("net/igc: add skeleton")
>> Cc: alvinx.zhang@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>>
>> ---
>> v2:
>> remove unnecessary parameters, move declaration to relevant header
>> file
>> ---
>> v3:
>> remove redundant code, optimize commit log
>> ---
>> v4:
>> rework patch
>> ---
>> drivers/net/igc/igc_ethdev.c | 9 ++++++++-
>> drivers/net/igc/igc_txrx.c | 8 ++++----
>> drivers/net/igc/igc_txrx.h | 6 ++++++
>> 3 files changed, 18 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/igc/igc_ethdev.c
>> b/drivers/net/igc/igc_ethdev.c index
>> b9933b395d..7f221a5d34 100644
>> --- a/drivers/net/igc/igc_ethdev.c
>> +++ b/drivers/net/igc/igc_ethdev.c
>> @@ -1240,8 +1240,15 @@ eth_igc_dev_init(struct rte_eth_dev *dev)
>> * has already done this work. Only check we don't need a different
>> * RX function.
>> */
>> - if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>> + if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
>> + dev->rx_pkt_burst = igc_recv_pkts;
>> + if (dev->data->scattered_rx)
>> + dev->rx_pkt_burst = igc_recv_scattered_pkts;
>
>Please removed the redundant code in igc_rx_init
Only the main process will execute "igc_rx_init", and the secondary process will not execute it.
So, the data path of the secondary process is not initialized.
The code that this patch adds to initialize the data path in "dev_init" will only be executed in the
secondary process. The same code in "igc_rx_init" is not redundant.
May I ask if the commit log is confusing, and should I submit new patch to correct it?
Regards
Zhichao
next prev parent reply other threads:[~2022-07-01 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220615073915.13309-1-zhichaox.zeng@intel.com>
2022-06-22 10:49 ` [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp zhichaox.zeng
2022-06-23 3:50 ` Zhang, Qi Z
2022-06-28 6:20 ` [PATCH v3] net/igc: move the initialization of data path into dev_init zhichaox.zeng
2022-06-28 7:00 ` Zhang, Qi Z
2022-06-30 11:03 ` [PATCH v4] net/igc: add support for secondary processes zhichaox.zeng
2022-06-30 11:47 ` Zhang, Qi Z
2022-07-01 3:13 ` Zeng, ZhichaoX [this message]
2022-07-01 3:47 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR11MB5602142F983156BBAF7D2DF4F1BD9@CO6PR11MB5602.namprd11.prod.outlook.com \
--to=zhichaox.zeng@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).