From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"alvinx.zhang@intel.com" <alvinx.zhang@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>,
"Su, Simei" <simei.su@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: RE: [PATCH v3] net/igc: move the initialization of data path into dev_init
Date: Tue, 28 Jun 2022 07:00:25 +0000 [thread overview]
Message-ID: <DM4PR11MB599479269C02C392FA33ED40D7B89@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220628062052.5397-1-zhichaox.zeng@intel.com>
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, June 28, 2022 2:21 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zeng, ZhichaoX <zhichaox.zeng@intel.com>;
> alvinx.zhang@intel.com; Guo, Junfeng <junfeng.guo@intel.com>; Su, Simei
> <simei.su@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH v3] net/igc: move the initialization of data path into dev_init
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> The upper-layer application usually call the common interface "dev_init"
> to initialize the data path, but in the igc driver, the initialization of data path is in
> "igc_rx_init" and "eth_igc_tx_queue_setup", while in other drivers it is in
> "dev_init". So when upper-layer application calling these function pointers will
> occur segmentation faults.
NO, for most intel PMD e.g.: i40e and ice, we don't initialize data path in dev_init.
>
> This patch moves the initialization of data path into "eth_igc_dev_init"
> to avoid segmentation faults, which is consistent with other drivers.
I saw dev->rx_pkt_burst can be overwritten in igc_rx_init, I assume the issue still be exist.
next prev parent reply other threads:[~2022-06-28 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220615073915.13309-1-zhichaox.zeng@intel.com>
2022-06-22 10:49 ` [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp zhichaox.zeng
2022-06-23 3:50 ` Zhang, Qi Z
2022-06-28 6:20 ` [PATCH v3] net/igc: move the initialization of data path into dev_init zhichaox.zeng
2022-06-28 7:00 ` Zhang, Qi Z [this message]
2022-06-30 11:03 ` [PATCH v4] net/igc: add support for secondary processes zhichaox.zeng
2022-06-30 11:47 ` Zhang, Qi Z
2022-07-01 3:13 ` Zeng, ZhichaoX
2022-07-01 3:47 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB599479269C02C392FA33ED40D7B89@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).