From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "david.marchand@6wind.com" <david.marchand@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
Date: Sat, 8 Oct 2016 12:47:59 +0000 [thread overview]
Message-ID: <DB5PR0401MB205420FE835BE96E45D7838390D90@DB5PR0401MB2054.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3500403.rczxDexAsB@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, October 07, 2016 7:15 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: david.marchand@6wind.com; dev@dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
>
> 2016-10-07 19:03, Shreyansh Jain:
> > DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> > DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
>
> Why not RTE_ prefix instead of EAL_?
Because while searching for similar naming pattern I came across other macros like EAL_REGISTER_TAILQ which were within librte_eal/eal/* folders.
> Why 3 patches? As there is no specific comment in each, I think you can
> squash.
Because each of the patch are common and tightly related changes. The replacement touches a large number of files, even though the change itself is small. By splitting, it makes review (or minor misses) easier - at least for me.
Anyways, if as a maintainer you prefer having a single bulk, I have no issues.
I will send next version with RTE_* and the 'grep -E' suggestion from Neil.
-
Shreyansh
next prev parent reply other threads:[~2016-10-08 12:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 13:33 Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 2/3] eal/drivers: prefix VDEV driver REGISTER macro " Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 3/3] eal/drivers: prefix driver param " Shreyansh Jain
2016-10-07 13:41 ` [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros " Shreyansh Jain
2016-10-07 13:51 ` Thomas Monjalon
2016-10-07 14:18 ` Neil Horman
2016-10-08 13:01 ` Shreyansh Jain
2016-10-08 13:00 ` Shreyansh Jain
2016-10-10 12:56 ` Neil Horman
2016-10-11 6:36 ` Shreyansh Jain
2016-10-11 7:27 ` Thomas Monjalon
2016-10-11 13:38 ` Neil Horman
2016-10-11 13:57 ` Thomas Monjalon
2016-10-11 14:57 ` Neil Horman
2016-10-12 4:29 ` Shreyansh Jain
2016-10-07 13:45 ` Thomas Monjalon
2016-10-08 12:47 ` Shreyansh Jain [this message]
2016-10-17 13:09 ` Neil Horman
2016-10-08 18:01 ` [dpdk-dev] [PATCH v1] drivers: prefix driver REGISTER macro with RTE EAL Shreyansh Jain
2016-10-08 18:02 ` Shreyansh Jain
2016-10-08 18:05 ` [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD Shreyansh Jain
2016-10-08 20:21 ` Thomas Monjalon
2016-10-09 15:12 ` Shreyansh Jain
2016-10-09 19:50 ` Thomas Monjalon
2016-10-10 5:11 ` Shreyansh Jain
2016-10-10 5:16 ` Shreyansh Jain
2016-10-10 5:43 ` [dpdk-dev] [PATCH v3] " Shreyansh Jain
2016-10-13 23:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR0401MB205420FE835BE96E45D7838390D90@DB5PR0401MB2054.eurprd04.prod.outlook.com \
--to=shreyansh.jain@nxp.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).