From: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
To: "K.E., Jesna" <Jesna.K.e@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <Ferruh.Yigit@amd.com>
Subject: RE: [PATCH v3] net/axgbe: invoke correct API when offloads enabled
Date: Wed, 15 Nov 2023 12:54:12 +0000 [thread overview]
Message-ID: <DM4PR12MB50554CA02DA2AF9EAAAF9BEB8DB1A@DM4PR12MB5055.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231115055604.583724-1-jesna.k.e@amd.com>
[Public]
Acked-by: Selwin Sebastian<selwin.sebastian@amd.com>
-----Original Message-----
From: K.E., Jesna <Jesna.K.e@amd.com>
Sent: Wednesday, November 15, 2023 11:26 AM
To: dev@dpdk.org
Cc: Yigit, Ferruh <Ferruh.Yigit@amd.com>; Sebastian, Selwin <Selwin.Sebastian@amd.com>; K.E., Jesna <Jesna.K.e@amd.com>
Subject: [PATCH v3] net/axgbe: invoke correct API when offloads enabled
A bug was introduced with the recent fix that when an offload feature is enabled axgbe_xmit_pkts_vec API is called rather than axgbe_xmit_pkts API.This patch fixes it.
Fixes: 9963b5131af8 ("net/axgbe: support multi-process")
Signed-off-by: Jesna K E <jesna.k.e@amd.com>
---
drivers/net/axgbe/axgbe_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 3717166384..f174d46143 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -12,6 +12,8 @@
#include "eal_filesystem.h"
+#include <rte_vect.h>
+
#ifdef RTE_ARCH_X86
#include <cpuid.h>
#else
@@ -2137,6 +2139,8 @@ axgbe_set_tx_function(struct rte_eth_dev *dev) {
struct axgbe_port *pdata = dev->data->dev_private;
+ dev->tx_pkt_burst = &axgbe_xmit_pkts;
+
if (pdata->multi_segs_tx)
dev->tx_pkt_burst = &axgbe_xmit_pkts_seg; #ifdef RTE_ARCH_X86 @@ -2144,8 +2148,6 @@ axgbe_set_tx_function(struct rte_eth_dev *dev)
if (!txq->vector_disable &&
rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
dev->tx_pkt_burst = &axgbe_xmit_pkts_vec; -#else
- dev->tx_pkt_burst = &axgbe_xmit_pkts;
#endif
}
--
2.34.1
next prev parent reply other threads:[~2023-11-15 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 16:00 [PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU Jesna K E
2023-11-11 16:00 ` [PATCH v1 2/3] net/axgbe: correct API call when offload enabled Jesna K E
2023-11-13 15:23 ` Ferruh Yigit
2023-11-13 16:55 ` Ferruh Yigit
2023-11-14 6:07 ` [PATCH v2] net/axgbe: invoke correct API when offloads enabled Jesna K E
2023-11-14 7:15 ` Jesna K E
2023-11-15 5:56 ` [PATCH v3] " Jesna K E
2023-11-15 11:57 ` Ferruh Yigit
2023-11-15 12:54 ` Sebastian, Selwin [this message]
2023-11-15 12:59 ` Ferruh Yigit
2023-11-11 16:00 ` [PATCH v1 3/3] net/axgbe: support TSO Implementation Jesna K E
2023-11-15 19:33 ` Ferruh Yigit
2023-11-16 9:44 ` [PATCH v2] net/axgbe: support TSO Jesna K E
2023-11-16 16:03 ` [PATCH v3] " Jesna K E
2023-11-17 18:34 ` Ferruh Yigit
2023-11-13 15:07 ` [PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB50554CA02DA2AF9EAAAF9BEB8DB1A@DM4PR12MB5055.namprd12.prod.outlook.com \
--to=selwin.sebastian@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=Jesna.K.e@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).