DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour
Date: Mon, 6 Mar 2017 02:13:37 +0000	[thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB74E01@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAC9B50@IRSMSX109.ger.corp.intel.com>

Thanks, Konstantin.

--Zhiyong

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Sunday, March 5, 2017 9:03 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour
> 
> 
> > The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to
> > transmit output packets on the output queue for DPDK applications as
> > follows.
> >
> > static inline uint16_t
> > rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
> >                  struct rte_mbuf **tx_pkts, uint16_t nb_pkts);
> >
> > Note: The fourth parameter nb_pkts: The number of packets to transmit.
> >
> > The rte_eth_tx_burst() function returns the number of packets it
> > actually sent. Most of PMD drivers can support the policy "send as
> > many packets to transmit as possible" at the PMD level. but the few of
> > PMDs have some sort of artificial limits for the pkts sent
> > successfully. For example, VHOST tx burst size is limited to 32
> > packets. Some rx_burst functions have the similar problem. The main
> > benefit is consistent batching behavior for user to simplify their
> > logic and avoid misusage at the application level, there is unified
> > rte_eth_tx/rx_burst interface already, there is no reason for inconsistent
> behaviors.
> > This patchset fixes it via adding wrapper function at the PMD level.
> >
> > Changes in V2:
> > 1. rename ixgbe, i40e and fm10k vec function XXX_xmit_pkts_vec to new
> > name XXX_xmit_fixed_burst_vec, new wrapper functions use original
> name
> > XXX_xmit_pkts_vec according to Bruce's suggestion.
> >
> > 2. simplify the code to avoid the if or if/else.
> >
> > Zhiyong Yang (5):
> >   net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size
> >   net/i40e: remove limit of i40e_xmit_pkts_vec burst size
> >   net/ixgbe: remove limit of ixgbe_xmit_pkts_vec burst size
> >   net/vhost: remove limit of vhost TX burst size
> >   net/vhost: remove limit of vhost RX burst size
> >
> >  drivers/net/fm10k/fm10k.h               |  4 ++--
> >  drivers/net/fm10k/fm10k_ethdev.c        | 28
> ++++++++++++++++++++++++---
> >  drivers/net/fm10k/fm10k_rxtx_vec.c      |  4 ++--
> >  drivers/net/i40e/i40e_rxtx.c            | 28 ++++++++++++++++++++++++---
> >  drivers/net/i40e/i40e_rxtx.h            |  4 ++--
> >  drivers/net/i40e/i40e_rxtx_vec_neon.c   |  4 ++--
> >  drivers/net/i40e/i40e_rxtx_vec_sse.c    |  4 ++--
> >  drivers/net/ixgbe/ixgbe_rxtx.c          | 29
> ++++++++++++++++++++++++++++
> >  drivers/net/ixgbe/ixgbe_rxtx.h          |  4 ++--
> >  drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c |  4 ++--
> > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c  |  4 ++--
> >  drivers/net/vhost/rte_eth_vhost.c       | 34
> +++++++++++++++++++++++++++++----
> >  12 files changed, 125 insertions(+), 26 deletions(-)
> >
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> > --
> > 2.7.4

  reply	other threads:[~2017-03-06  2:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24  8:48 [dpdk-dev] [PATCH " Zhiyong Yang
2017-02-24  8:48 ` [dpdk-dev] [PATCH 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-02-24  9:32   ` Bruce Richardson
2017-02-24  9:36     ` Bruce Richardson
2017-02-24  9:48       ` Yang, Zhiyong
2017-03-03 11:17   ` [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour Zhiyong Yang
2017-03-03 11:17     ` [dpdk-dev] [PATCH v2 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-03-29  7:16       ` [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour Zhiyong Yang
2017-03-29  7:16         ` [dpdk-dev] [PATCH v3 1/5] net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size Zhiyong Yang
2017-03-29  7:16         ` [dpdk-dev] [PATCH v3 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec " Zhiyong Yang
2017-03-29  7:16         ` [dpdk-dev] [PATCH v3 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-03-29  7:16         ` [dpdk-dev] [PATCH v3 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-03-29  7:16         ` [dpdk-dev] [PATCH v3 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-03-30 12:54         ` [dpdk-dev] [PATCH v3 0/5] consistent PMD batching behaviour Ferruh Yigit
2017-03-31  7:00           ` Yao, Lei A
2017-03-03 11:17     ` [dpdk-dev] [PATCH v2 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec burst size Zhiyong Yang
2017-03-24 14:03       ` Ferruh Yigit
2017-03-03 11:17     ` [dpdk-dev] [PATCH v2 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-03-03 11:17     ` [dpdk-dev] [PATCH v2 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-03-03 11:17     ` [dpdk-dev] [PATCH v2 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-03-05 13:02     ` [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour Ananyev, Konstantin
2017-03-06  2:13       ` Yang, Zhiyong [this message]
2017-03-24 14:02     ` Ferruh Yigit
2017-03-25  6:29       ` Yang, Zhiyong
2017-03-28 10:00       ` Yang, Zhiyong
2017-03-28 10:05         ` Ferruh Yigit
2017-02-24  8:48 ` [dpdk-dev] [PATCH 2/5] net/i40e: remove limit of i40e_xmit_pkts_vec burst size Zhiyong Yang
2017-02-24  8:48 ` [dpdk-dev] [PATCH 3/5] net/ixgbe: remove limit of ixgbe_xmit_pkts_vec " Zhiyong Yang
2017-02-24  8:48 ` [dpdk-dev] [PATCH 4/5] net/vhost: remove limit of vhost TX " Zhiyong Yang
2017-02-24 11:08   ` Kevin Traynor
2017-02-24 13:04     ` Bruce Richardson
2017-02-24 13:33       ` Kevin Traynor
2017-03-01  9:44   ` Maxime Coquelin
2017-03-01 13:24     ` Yang, Zhiyong
2017-02-24  8:48 ` [dpdk-dev] [PATCH 5/5] net/vhost: remove limit of vhost RX " Zhiyong Yang
2017-02-24 11:41   ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A3EB74E01@BGSMSX101.gar.corp.intel.com \
    --to=zhiyong.yang@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).