From: "Liu, Changpeng" <changpeng.liu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application
Date: Wed, 19 Jul 2017 04:24:12 +0000 [thread overview]
Message-ID: <FF7FC980937D6342B9D289F5F3C7C2625B59A780@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <6331570.OI5S64Z1KD@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 19, 2017 12:19 PM
> To: Liu, Changpeng <changpeng.liu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-
> scsi sample application
>
> 19/07/2017 03:20, Liu, Changpeng:
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: Tuesday, July 18, 2017 10:24 PM
> > > To: Liu, Changpeng <changpeng.liu@intel.com>
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-
> user-
> > > scsi sample application
> > >
> > > Hi,
> > >
> > > 15/07/2017 11:20, Changpeng Liu:
> > > > --- /dev/null
> > > > +++ b/examples/vhost_scsi/scsi_spec.h
> > > > @@ -0,0 +1,488 @@
> > > > +/*-
> > > > + * BSD LICENSE
> > > > + *
> > > > + * Copyright (c) Intel Corporation.
> > > > + * All rights reserved.
> > > > + *
> > > > + * Redistribution and use in source and binary forms, with or without
> > > > + * modification, are permitted provided that the following conditions
> > > > + * are met:
> > > > + *
> > > > + * * Redistributions of source code must retain the above copyright
> > > > + * notice, this list of conditions and the following disclaimer.
> > > > + * * Redistributions in binary form must reproduce the above copyright
> > > > + * notice, this list of conditions and the following disclaimer in
> > > > + * the documentation and/or other materials provided with the
> > > > + * distribution.
> > > > + * * Neither the name of Intel Corporation nor the names of its
> > > > + * contributors may be used to endorse or promote products derived
> > > > + * from this software without specific prior written permission.
> > > > + *
> > > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> > > CONTRIBUTORS
> > > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> NOT
> > > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> > > FITNESS FOR
> > > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > > COPYRIGHT
> > > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > > INCIDENTAL,
> > > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> > > NOT
> > > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
> OF
> > > USE,
> > > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> AND
> > > ON ANY
> > > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> TORT
> > > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> OF
> > > THE USE
> > > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > > DAMAGE.
> > > > + */
> > > > +
> > > > +#ifndef _SCSI_SPEC_H
> > > > +#define _SCSI_SPEC_H
> > >
> > > This file is full of specification values.
> > > Ideally it should be included from somewhere else.
> > > If not possible, please add a comment in this file to explain where
> > > it comes from. Is it copied from other projects?
> >
> > As I know, Linux has one library iscsi-devel contains some definition
> > of the SCSI specification, again the library is not good enough, so I
> > reuse the code from SPDK(https://github.com/spdk/spdk, BSD licensed).
> > > Is there a link to the specification?
> > Please find the link to the SCSI Primary Commands 3 and SCSI Block Commands
> 3
> > specifications from the following link:
> > http://www.t10.org/drafts.htm#SPC_Family
>
> Please, add these comments in the file.
Okay, also will add SPDK link to document.
next prev parent reply other threads:[~2017-07-19 4:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:28 [dpdk-dev] [PATCH] " Changpeng Liu
2017-07-07 0:50 ` Yuanhan Liu
2017-07-07 2:00 ` Liu, Changpeng
2017-07-07 2:09 ` Yuanhan Liu
2017-07-08 4:14 ` [dpdk-dev] [PATCH v2] " Changpeng Liu
2017-07-07 4:48 ` Yuanhan Liu
2017-07-07 4:54 ` Liu, Changpeng
2017-07-08 5:21 ` [dpdk-dev] [PATCH v3] " Changpeng Liu
2017-07-07 5:07 ` Yuanhan Liu
2017-07-07 8:40 ` Hemant Agrawal
2017-07-07 9:44 ` Yuanhan Liu
2017-07-07 12:21 ` Thomas Monjalon
2017-07-08 2:53 ` Yuanhan Liu
2017-07-09 16:42 ` Thomas Monjalon
2017-07-12 14:49 ` Wodkowski, PawelX
2017-07-15 8:20 ` [dpdk-dev] [PATCH v4] " Changpeng Liu
2017-07-18 14:24 ` Thomas Monjalon
2017-07-19 0:20 ` Liu, Changpeng
2017-07-19 4:18 ` Thomas Monjalon
2017-07-19 4:24 ` Liu, Changpeng [this message]
2017-07-20 9:16 ` [dpdk-dev] [PATCH v5] " Changpeng Liu
2017-07-19 19:48 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF7FC980937D6342B9D289F5F3C7C2625B59A780@SHSMSX103.ccr.corp.intel.com \
--to=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).