From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"alialnu@nvidia.com" <alialnu@nvidia.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"ci@dpdk.org" <ci@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: RE: [EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection
Date: Fri, 29 Sep 2023 10:16:46 +0000 [thread overview]
Message-ID: <PH0PR18MB4086255AC56AA59E1DC71815DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8z9bi3wR8J+Jpg+UjT-MmJyh5q0x+i11i-f+=UNB9g4oA@mail.gmail.com>
> On Fri, Sep 29, 2023 at 11:21 AM Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com> wrote:
> > > -----Original Message-----
> > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > Sent: Friday, September 29, 2023 2:05 PM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; alialnu@nvidia.com;
> > > aconole@redhat.com
> > > Cc: ci@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> > > Subject: [PATCH] pw_maintainers_cli: enhance tree selection
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > When longest prefix match doesnt find a suitable tree, pick the
> > > tree which has the highest modified file count instead of defauting
> > > to main tree.
> > >
>
> This script helps with the delegation but nothing prevents submitters
> or maintainers from updating this in patchwork themselves.
>
The script is used by CI to decide which branch to apply the patches on
and run the tests.
For example in the CI run http://mails.dpdk.org/archives/test-report/2023-September/468555.html
the script incorrectly picks dpdk main tree instead of dpdk-next-event and fails.
> I did not test it but this heuristic seems complex in how it is
> affected by existing git history.
> It makes this script harder to understand / predict the outcome.
> I fear side effects.
>
It is not based on git history, It picks the tree based on the files that were changed in the patch.
Also, it only effects the case where its not able to find the common tree.
>
> >
> > This change is need to find the correct branch when a patch has a
> specification
> > Change followed by a implementation of driver layer example:
>
> This should be in the commitlog from the start as it exposes the need,
> rather than the solution implemented by the patch.
>
I can change this in the next version.
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
> 3D29675&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-
> fmvgGV3o-
> g_fjLhk5Pupi9ijohpc&m=QbsEVS0vy8B7ZVY0WPAMjlHbfOxASgG_XP4P7_pri
> aunQeURVo3SJaIvt3GsjfMe&s=kdARtlZA5zKbOuliw3uJFntF-
> IjXGY8OXli9SkD2rDg&e=
>
>
>
> --
> David Marchand
next prev parent reply other threads:[~2023-09-29 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:34 pbhagavatula
2023-09-29 9:21 ` Pavan Nikhilesh Bhagavatula
2023-09-29 9:40 ` David Marchand
2023-09-29 10:16 ` Pavan Nikhilesh Bhagavatula [this message]
2023-09-29 10:21 ` Thomas Monjalon
2023-09-29 10:54 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-09-29 11:09 ` Thomas Monjalon
2023-09-29 11:13 ` Jerin Jacob Kollanukkaran
2023-09-29 13:17 ` [PATCH v2] pw_maintainers_cli: enhance ci " pbhagavatula
2023-10-12 12:59 ` Aaron Conole
2023-10-13 5:55 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-12-07 13:33 ` Pavan Nikhilesh Bhagavatula
2023-12-07 13:44 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4086255AC56AA59E1DC71815DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=aconole@redhat.com \
--cc=alialnu@nvidia.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).