From: Matej Vido <vido@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names
Date: Wed, 31 May 2017 10:32:02 +0200 [thread overview]
Message-ID: <c0646fab-99f9-654b-f5f1-564e9df00de8@cesnet.cz> (raw)
In-Reply-To: <b89a6f4e-29e4-8594-fa99-ba53f7cc7531@intel.com>
On 29.05.2017 14:40, Ferruh Yigit wrote:
> On 5/26/2017 7:05 PM, Matej Vido wrote:
>> Signed-off-by: Matej Vido <vido@cesnet.cz>
> Hi Matej,
>
> Overall patchset looks good to me, but can you please provide a little
> more information in commit logs, please check comments on patches.
>
> For this patch, it seems refactor naming is removing "cgmii", what is
> the reason of this, is cgmii no more true or adding different interface?
>
> Thanks,
> ferruh
Hi Ferruh,
ok, I will address the comments in v2.
"cgmii" was too specific. There can be different ibuf/obuf modules in
different firmwares. But the address space definition is the same for
all ibuf/obuf modules in all firmwares so this patch makes the name
general (and also shorter).
Regards,
Matej
>
>> ---
>> drivers/net/szedata2/rte_eth_szedata2.c | 80 +++++++++++++++---------------
>> drivers/net/szedata2/rte_eth_szedata2.h | 48 +++++++++---------
>> 2 files changed, 64 insertions(+), 64 deletions(-)
> <...>
next prev parent reply other threads:[~2017-05-31 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 18:05 Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-05-29 12:41 ` Ferruh Yigit
2017-05-31 8:33 ` Matej Vido
2017-05-31 9:12 ` Ferruh Yigit
2017-05-26 18:05 ` [dpdk-dev] [PATCH 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-05-29 12:42 ` Ferruh Yigit
2017-05-31 8:34 ` Matej Vido
2017-05-31 9:11 ` Ferruh Yigit
2017-05-29 12:40 ` [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names Ferruh Yigit
2017-05-31 8:32 ` Matej Vido [this message]
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 " Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-06-12 14:35 ` [dpdk-dev] [PATCH v2 1/5] net/szedata2: refactor ibuf and obuf names Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0646fab-99f9-654b-f5f1-564e9df00de8@cesnet.cz \
--to=vido@cesnet.cz \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).