From: yang_y_yi <yang_y_yi@163.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: "Yi Yang (杨燚)-云服务集团" <yangyi01@inspur.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jiayu.hu@intel.com" <jiayu.hu@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] 答复: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
Date: Thu, 30 Jul 2020 18:44:55 +0800 (CST) [thread overview]
Message-ID: <1307476d.6b96.1739f532f27.Coremail.yang_y_yi@163.com> (raw)
In-Reply-To: <26165953.ALDsH63Fg3@thomas>
Got it. Thanks a lot.
在 2020-07-30 18:42:38,"Thomas Monjalon" <thomas@monjalon.net> 写道:
>30/07/2020 12:39, Yi Yang (杨燚)-云服务集团:
>> Thomas, do you mean I need to change the below files to add deprecation notice about free_cb?
>
>No it should be a separate patch for announing the deprecation in 20.08.
>
>Below patches cannot be applied in 20.08.
>
>
>>
>> doc/guides/rel_notes/deprecation.rst
>> doc/guides/rel_notes/release_20_08.rst
>>
>> I'll use --cc-cmd devtools/get-maintainer.sh to send a new version including deprecation notice you mentioned.
>>
>> -----邮件原件-----
>> 发件人: Thomas Monjalon [mailto:thomas@monjalon.net]
>> 发送时间: 2020年7月30日 18:17
>> 收件人: yang_y_yi@163.com
>> 抄送: dev@dpdk.org; jiayu.hu@intel.com; Yi Yang (杨燚)-云服务集团 <yangyi01@inspur.com>; yang_y_yi@163.com; olivier.matz@6wind.com
>> 主题: Re: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case
>>
>> 30/07/2020 11:56, yang_y_yi@163.com:
>> > --- a/lib/librte_mbuf/rte_mbuf.h
>> > +++ b/lib/librte_mbuf/rte_mbuf.h
>> > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
>> > RTE_ASSERT(m->shinfo != NULL);
>> >
>> > if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0)
>> > - m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque);
>> > + m->shinfo->free_cb(m, m->shinfo->fcb_opaque);
>> > }
>> >
>> > /**
>> > diff --git a/lib/librte_mbuf/rte_mbuf_core.h
>> > b/lib/librte_mbuf/rte_mbuf_core.h index 8cd7137..d194429 100644
>> > --- a/lib/librte_mbuf/rte_mbuf_core.h
>> > +++ b/lib/librte_mbuf/rte_mbuf_core.h
>> > @@ -671,7 +671,7 @@ struct rte_mbuf {
>> > /**
>> > * Function typedef of callback to free externally attached buffer.
>> > */
>> > -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void
>> > *opaque);
>> > +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *,
>> > +void *);
>>
>> I think a deprecation notice is required in 20.08 in order to apply such change in 20.11.
>>
>> Please use --cc-cmd devtools/get-maintainer.sh when sending a patch.
>>
>>
>>
>
>
>
>
next prev parent reply other threads:[~2020-07-30 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:56 [dpdk-dev] [PATCH 0/3] Fix external mbuf free issue in " yang_y_yi
2020-07-30 9:56 ` [dpdk-dev] [PATCH 1/3] gso: fix refcnt update issue for external mbuf yang_y_yi
2020-07-30 9:56 ` [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case yang_y_yi
2020-07-30 10:16 ` Thomas Monjalon
[not found] ` <f16b530ed9234b988241d5c4b4329d1b@inspur.com>
2020-07-30 10:42 ` [dpdk-dev] 答复: " Thomas Monjalon
2020-07-30 10:44 ` yang_y_yi [this message]
2020-07-30 12:18 ` yang_y_yi
2020-07-30 9:56 ` [dpdk-dev] [PATCH 3/3] vhost: use new free_cb interface to fix mbuf free issue yang_y_yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307476d.6b96.1739f532f27.Coremail.yang_y_yi@163.com \
--to=yang_y_yi@163.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=yangyi01@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).