* [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument
@ 2015-03-23 8:11 gaohaifeng
2015-03-23 16:13 ` Olivier MATZ
0 siblings, 1 reply; 3+ messages in thread
From: gaohaifeng @ 2015-03-23 8:11 UTC (permalink / raw)
To: jerry.lilijun, olivier.matz, thomas.monjalon, dev
From: Haifeng Gao <gaohaifeng.gao@huawei.com>
eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
It needs to reset create_uio_dev explicitly.
Signed-off-by: Haifeng Gao <gaohaifeng.gao@huawei.com>
---
lib/librte_eal/common/eal_common_options.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 4319549..8fcb1ab 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -70,7 +70,7 @@ eal_short_options[] =
const struct option
eal_long_options[] = {
{OPT_BASE_VIRTADDR, 1, NULL, OPT_BASE_VIRTADDR_NUM },
- {OPT_CREATE_UIO_DEV, 1, NULL, OPT_CREATE_UIO_DEV_NUM },
+ {OPT_CREATE_UIO_DEV, 0, NULL, OPT_CREATE_UIO_DEV_NUM },
{OPT_FILE_PREFIX, 1, NULL, OPT_FILE_PREFIX_NUM },
{OPT_HELP, 0, NULL, OPT_HELP_NUM },
{OPT_HUGE_DIR, 1, NULL, OPT_HUGE_DIR_NUM },
@@ -131,6 +131,7 @@ eal_reset_internal_config(struct internal_config *internal_cfg)
internal_cfg->no_hpet = 1;
#endif
internal_cfg->vmware_tsc_map = 0;
+ internal_cfg->create_uio_dev = 0;
}
/*
--
1.7.12.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument
2015-03-23 8:11 [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument gaohaifeng
@ 2015-03-23 16:13 ` Olivier MATZ
2015-03-23 16:37 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Olivier MATZ @ 2015-03-23 16:13 UTC (permalink / raw)
To: gaohaifeng, jerry.lilijun, thomas.monjalon, dev
Hi,
On 03/23/2015 09:11 AM, gaohaifeng wrote:
> From: Haifeng Gao <gaohaifeng.gao@huawei.com>
>
> eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
> It needs to reset create_uio_dev explicitly.
>
> Signed-off-by: Haifeng Gao <gaohaifeng.gao@huawei.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thank you for fixing this.
Note for Thomas: the bug is there since my initial commit adding
the feature, you may want to add this to the commit log:
Fixes: f7f97c16048e (" pci: add option --create-uio-dev to run without
hotplug")
Regards,
Olivier
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument
2015-03-23 16:13 ` Olivier MATZ
@ 2015-03-23 16:37 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-23 16:37 UTC (permalink / raw)
To: gaohaifeng; +Cc: dev
> > eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
> > It needs to reset create_uio_dev explicitly.
> >
> > Signed-off-by: Haifeng Gao <gaohaifeng.gao@huawei.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Thank you for fixing this.
>
> Note for Thomas: the bug is there since my initial commit adding
> the feature, you may want to add this to the commit log:
> Fixes: f7f97c16048e (" pci: add option --create-uio-dev to run without
> hotplug")
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-23 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 8:11 [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev option to no argument gaohaifeng
2015-03-23 16:13 ` Olivier MATZ
2015-03-23 16:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).