[dpdk-dev] [PATCH] net/i40e: fix uninitialized variable

[dpdk-dev] [PATCH] net/i40e: fix uninitialized variable

[Yong Wang]

In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
func call i40evf_dev_atomic_write_link_status(), but is uninitialized.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 73c315a..3c0f436 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2218,6 +2218,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
 	new_link.link_status = vf->link_up ? ETH_LINK_UP :
 					     ETH_LINK_DOWN;
+	new_link.link_autoneg = ETH_LINK_AUTONEG;
 
 	i40evf_dev_atomic_write_link_status(dev, &new_link);
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/i40e: fix uninitialized variable

[Wu, Jingjing]

> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Friday, September 22, 2017 3:18 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH] net/i40e: fix uninitialized variable
> 
> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index 73c315a..3c0f436 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2218,6 +2218,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device
> *pci_dev)
>  	new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
>  	new_link.link_status = vf->link_up ? ETH_LINK_UP :
>  					     ETH_LINK_DOWN;
> +	new_link.link_autoneg = ETH_LINK_AUTONEG;
> 
It is right, but it will be better to set it by checking (dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED)?

And if your patch is fixing some issue, please add fixes line in your patch, and Cc: stable@dpdk.org


Thanks
Jingjing