* [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation
@ 2018-06-19 13:08 Raslan Darawsheh
2018-06-20 5:34 ` Shahaf Shuler
2018-06-21 7:30 ` [dpdk-dev] [PATCH v2] net/mlx5: fix RSS " Raslan Darawsheh
0 siblings, 2 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2018-06-19 13:08 UTC (permalink / raw)
To: shahafs; +Cc: dev, matan, stable
When setting the level in rss action it's checking for the value
stored in the parser which is set to 0 by default.
this change the check to be for the requested action insted.
Fixes: d4a40518 ("net/mlx5: support tunnel RSS level")
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 994be05..40df633 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
return -rte_errno;
}
#ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
- if (parser->rss_conf.level > 1) {
+ if (rss->level > 1) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions,
@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev,
return -rte_errno;
}
#endif
- if (parser->rss_conf.level > 2) {
+ if (rss->level > 2) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
actions,
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation 2018-06-19 13:08 [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation Raslan Darawsheh @ 2018-06-20 5:34 ` Shahaf Shuler 2018-06-20 7:10 ` Nélio Laranjeiro 2018-06-21 7:30 ` [dpdk-dev] [PATCH v2] net/mlx5: fix RSS " Raslan Darawsheh 1 sibling, 1 reply; 4+ messages in thread From: Shahaf Shuler @ 2018-06-20 5:34 UTC (permalink / raw) To: Raslan Darawsheh, Yongseok Koh, Nélio Laranjeiro, Adrien Mazarguil Cc: dev, Matan Azrad, stable Adding the maintainers, Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh: >Subject: [PATCH] net/mlx5: fix Rss level validation Rss -> RSS > >When setting the level in rss action it's checking for the value stored in the >parser which is set to 0 by default. > >this change the check to be for the requested action insted. this -> This instead -> instead > >Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") > >Cc: stable@dpdk.org >Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> >--- > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c >index 994be05..40df633 100644 >--- a/drivers/net/mlx5/mlx5_flow.c >+++ b/drivers/net/mlx5/mlx5_flow.c >@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > return -rte_errno; > } > #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT >- if (parser->rss_conf.level > 1) { >+ if (rss->level > 1) { > rte_flow_error_set(error, EINVAL, > >RTE_FLOW_ERROR_TYPE_ACTION, > actions, >@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > return -rte_errno; > } > #endif >- if (parser->rss_conf.level > 2) { >+ if (rss->level > 2) { > rte_flow_error_set(error, EINVAL, > >RTE_FLOW_ERROR_TYPE_ACTION, > actions, >-- The above changes (if they are the only one) can be address by me when I apply the patch. Will wait few days for the maintainers comments. Acked-by: Shahaf Shuler <shahafs@mellanox.com> >2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation 2018-06-20 5:34 ` Shahaf Shuler @ 2018-06-20 7:10 ` Nélio Laranjeiro 0 siblings, 0 replies; 4+ messages in thread From: Nélio Laranjeiro @ 2018-06-20 7:10 UTC (permalink / raw) To: Shahaf Shuler Cc: Raslan Darawsheh, Yongseok Koh, Adrien Mazarguil, dev, Matan Azrad, stable On Wed, Jun 20, 2018 at 05:34:23AM +0000, Shahaf Shuler wrote: > Adding the maintainers, > > Tuesday, June 19, 2018 4:09 PM, Raslan Darawsheh: > >Subject: [PATCH] net/mlx5: fix Rss level validation > > Rss -> RSS > > > > >When setting the level in rss action it's checking for the value stored in the > >parser which is set to 0 by default. > > > >this change the check to be for the requested action insted. > > this -> This > instead -> instead > > > > >Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") > > > >Cc: stable@dpdk.org > >Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> > >--- > > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > >index 994be05..40df633 100644 > >--- a/drivers/net/mlx5/mlx5_flow.c > >+++ b/drivers/net/mlx5/mlx5_flow.c > >@@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT > >- if (parser->rss_conf.level > 1) { > >+ if (rss->level > 1) { > > rte_flow_error_set(error, EINVAL, > > > >RTE_FLOW_ERROR_TYPE_ACTION, > > actions, > >@@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > #endif > >- if (parser->rss_conf.level > 2) { > >+ if (rss->level > 2) { > > rte_flow_error_set(error, EINVAL, > > > >RTE_FLOW_ERROR_TYPE_ACTION, > > actions, > >-- > > The above changes (if they are the only one) can be address by me when I apply the patch. > Will wait few days for the maintainers comments. > > Acked-by: Shahaf Shuler <shahafs@mellanox.com> We should answer the same as the other patches, there is already a re-work remodeling the whole engine, this patch remains relevant for stables branches, but no more for mainline. Regards, -- Nélio Laranjeiro 6WIND ^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/mlx5: fix RSS level validation 2018-06-19 13:08 [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation Raslan Darawsheh 2018-06-20 5:34 ` Shahaf Shuler @ 2018-06-21 7:30 ` Raslan Darawsheh 1 sibling, 0 replies; 4+ messages in thread From: Raslan Darawsheh @ 2018-06-21 7:30 UTC (permalink / raw) To: shahafs; +Cc: dev, matan, nelio.laranjeiro, rasland, stable When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. This change the check to be for the requested action instead. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh <rasland@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> --- changes in v2: commit massage reword. --- --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 994be05..40df633 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT - if (parser->rss_conf.level > 1) { + if (rss->level > 1) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, @@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #endif - if (parser->rss_conf.level > 2) { + if (rss->level > 2) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-21 7:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-06-19 13:08 [dpdk-dev] [PATCH] net/mlx5: fix Rss level validation Raslan Darawsheh 2018-06-20 5:34 ` Shahaf Shuler 2018-06-20 7:10 ` Nélio Laranjeiro 2018-06-21 7:30 ` [dpdk-dev] [PATCH v2] net/mlx5: fix RSS " Raslan Darawsheh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).