* [dpdk-dev] [PATCH] net/i40e: update Tx offload mask
@ 2018-10-23 6:14 Beilei Xing
2018-10-24 20:40 ` Zhang, Qi Z
2018-10-25 5:35 ` Ye Xiaolong
0 siblings, 2 replies; 3+ messages in thread
From: Beilei Xing @ 2018-10-23 6:14 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, stable
Tx offload mask is updated in following commit:
commit 1037ed842c37 ("mbuf: fix Tx offload mask").
Currently, the new added offload flags will be
not supported in PMD and application will fail
to call PMD transmit prepare function.
This patch updates PMD Tx offload mask.
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index b2819f7..a827456 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -55,6 +55,10 @@
PKT_TX_OUTER_IP_CKSUM)
#define I40E_TX_OFFLOAD_MASK ( \
+ PKT_TX_OUTER_IPV4 | \
+ PKT_TX_OUTER_IPV6 | \
+ PKT_TX_IPV4 | \
+ PKT_TX_IPV6 | \
PKT_TX_IP_CKSUM | \
PKT_TX_L4_MASK | \
PKT_TX_OUTER_IP_CKSUM | \
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: update Tx offload mask
2018-10-23 6:14 [dpdk-dev] [PATCH] net/i40e: update Tx offload mask Beilei Xing
@ 2018-10-24 20:40 ` Zhang, Qi Z
2018-10-25 5:35 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2018-10-24 20:40 UTC (permalink / raw)
To: Xing, Beilei; +Cc: dev, stable
> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, October 23, 2018 1:15 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/i40e: update Tx offload mask
>
> Tx offload mask is updated in following commit:
> commit 1037ed842c37 ("mbuf: fix Tx offload mask").
> Currently, the new added offload flags will be not supported in PMD and
> application will fail to call PMD transmit prepare function.
> This patch updates PMD Tx offload mask.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: update Tx offload mask
2018-10-23 6:14 [dpdk-dev] [PATCH] net/i40e: update Tx offload mask Beilei Xing
2018-10-24 20:40 ` Zhang, Qi Z
@ 2018-10-25 5:35 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2018-10-25 5:35 UTC (permalink / raw)
To: Beilei Xing; +Cc: qi.z.zhang, dev, stable
On 10/23, Beilei Xing wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask").
>Currently, the new added offload flags will be
>not supported in PMD and application will fail
Shouldn't it be "the new added offlaod flags are not supported in PMD and xxxx"?
Thanks,
Xiaolong
>to call PMD transmit prepare function.
>This patch updates PMD Tx offload mask.
>
>Cc: stable@dpdk.org
>
>Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>---
> drivers/net/i40e/i40e_rxtx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>index b2819f7..a827456 100644
>--- a/drivers/net/i40e/i40e_rxtx.c
>+++ b/drivers/net/i40e/i40e_rxtx.c
>@@ -55,6 +55,10 @@
> PKT_TX_OUTER_IP_CKSUM)
>
> #define I40E_TX_OFFLOAD_MASK ( \
>+ PKT_TX_OUTER_IPV4 | \
>+ PKT_TX_OUTER_IPV6 | \
>+ PKT_TX_IPV4 | \
>+ PKT_TX_IPV6 | \
> PKT_TX_IP_CKSUM | \
> PKT_TX_L4_MASK | \
> PKT_TX_OUTER_IP_CKSUM | \
>--
>2.5.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-25 5:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 6:14 [dpdk-dev] [PATCH] net/i40e: update Tx offload mask Beilei Xing
2018-10-24 20:40 ` Zhang, Qi Z
2018-10-25 5:35 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).