DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild
@ 2020-10-28 18:15 luca.boccassi
  2020-10-29 20:58 ` Thomas Monjalon
  2020-11-11 12:16 ` [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass " luca.boccassi
  0 siblings, 2 replies; 5+ messages in thread
From: luca.boccassi @ 2020-10-28 18:15 UTC (permalink / raw)
  To: dev

From: Luca Boccassi <luca.boccassi@microsoft.com>

Necessary to get build flags from DKMS.

See:

https://git.dpdk.org/dpdk/commit/?id=816d967717

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
 linux/igb_uio/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild
index 98c98fe..3ab85c4 100644
--- a/linux/igb_uio/Kbuild
+++ b/linux/igb_uio/Kbuild
@@ -1 +1,2 @@
+ccflags-y := $(MODULE_CFLAGS)
 obj-m := igb_uio.o
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild
  2020-10-28 18:15 [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild luca.boccassi
@ 2020-10-29 20:58 ` Thomas Monjalon
  2020-10-30 16:33   ` Luca Boccassi
  2020-11-11 12:16 ` [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass " luca.boccassi
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2020-10-29 20:58 UTC (permalink / raw)
  To: luca.boccassi; +Cc: dev

28/10/2020 19:15, luca.boccassi@gmail.com:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Necessary to get build flags from DKMS.
> 
> See:
> 
> https://git.dpdk.org/dpdk/commit/?id=816d967717
[...]
> --- a/linux/igb_uio/Kbuild
> +++ b/linux/igb_uio/Kbuild
> @@ -1 +1,2 @@
> +ccflags-y := $(MODULE_CFLAGS)
>  obj-m := igb_uio.o

Yes this patch was not migrated because I though it was referring
to a DPDK-specific variable.
So you mean MODULE_CFLAGS is from the kernel build system?



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild
  2020-10-29 20:58 ` Thomas Monjalon
@ 2020-10-30 16:33   ` Luca Boccassi
  0 siblings, 0 replies; 5+ messages in thread
From: Luca Boccassi @ 2020-10-30 16:33 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Thu, 29 Oct 2020, 20:58 Thomas Monjalon, <thomas@monjalon.net> wrote:

> 28/10/2020 19:15, luca.boccassi@gmail.com:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Necessary to get build flags from DKMS.
> >
> > See:
> >
> > https://git.dpdk.org/dpdk/commit/?id=816d967717
> [...]
> > --- a/linux/igb_uio/Kbuild
> > +++ b/linux/igb_uio/Kbuild
> > @@ -1 +1,2 @@
> > +ccflags-y := $(MODULE_CFLAGS)
> >  obj-m := igb_uio.o
>
> Yes this patch was not migrated because I though it was referring
> to a DPDK-specific variable.
> So you mean MODULE_CFLAGS is from the kernel build system?
>

Yeah dkms uses it

>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass MODULE_CFLAGS in Kbuild
  2020-10-28 18:15 [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild luca.boccassi
  2020-10-29 20:58 ` Thomas Monjalon
@ 2020-11-11 12:16 ` luca.boccassi
  2020-11-11 12:22   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: luca.boccassi @ 2020-11-11 12:16 UTC (permalink / raw)
  To: dev; +Cc: thomas

From: Luca Boccassi <bluca@debian.org>

With the legacy build system MODULE_CFLAGS can be set to pass compiler
flags specific for the kernel modules builds.
This is used currently by Ubuntu and Debian.
Set ccflags-y in the Kbuild to achieve the same result with Meson, and
to keep backward compatbility with older scripts.

Fixes regression in Ubuntu/Debian when the Kbuild is included in the
DKMS source package, as DKMS will pick it up silently by default if
present, causing the MODULE_CFLAGS to be ignored.

Fixes: a52f4574f798 ("igb_uio: build with meson")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: backported original commit instead of making a new one

 linux/igb_uio/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild
index 98c98fe..3ab85c4 100644
--- a/linux/igb_uio/Kbuild
+++ b/linux/igb_uio/Kbuild
@@ -1 +1,2 @@
+ccflags-y := $(MODULE_CFLAGS)
 obj-m := igb_uio.o
-- 
2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass MODULE_CFLAGS in Kbuild
  2020-11-11 12:16 ` [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass " luca.boccassi
@ 2020-11-11 12:22   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-11-11 12:22 UTC (permalink / raw)
  To: luca.boccassi; +Cc: dev

11/11/2020 13:16, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
> 
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and
> to keep backward compatbility with older scripts.
> 
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the
> DKMS source package, as DKMS will pick it up silently by default if
> present, causing the MODULE_CFLAGS to be ignored.
> 
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: backported original commit instead of making a new one

Applied with original commit date,
and simpler explanation from the v1
because meson/make history is not relevant in this repo.



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-11 12:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 18:15 [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild luca.boccassi
2020-10-29 20:58 ` Thomas Monjalon
2020-10-30 16:33   ` Luca Boccassi
2020-11-11 12:16 ` [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass " luca.boccassi
2020-11-11 12:22   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git