From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Chas Williams <chas3@att.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled
Date: Mon, 20 Jan 2020 09:55:11 +0000 [thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729EF2F0AEF@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <4605926.oAaWjsssbx@xps>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, January 20, 2020 3:20 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>; Chas Williams
> <chas3@att.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Stephen Hemminger <stephen@networkplumber.org>; Pattan, Reshma
> <reshma.pattan@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is
> disabled
>
> Someone to review please?
>
> 23/12/2019 07:53, Reshma Pattan:
> > Some unit tests has dependency on RING PMD, so this patch is trying to
> > fix those and other closely related issues.
> >
> > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter unit
> > tests are dependent on ring PMD, so compile those tests only when ring
> > PMD is enabled else ignore.
> >
> > 2)get rid of make file error which was added by bond unit test for
> > ring PMD disabled case which is not necessary.
> >
> > 3)Tx adapter UT is dependent on RING PMD, but it was observed that it
> > was missing from the run in meson build, so added it. TX adapter UT
> > uses 'sw event and 'null' pmd drivers, so for shared builds the
> > drivers .so path has to be passed to the test args of meson UT run.
> >
> > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
> > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats
> > library")
> > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
> > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")
> >
> > CC: stable@dpdk.org
> > CC: Nikhil Rao <nikhil.rao@intel.com>
> > CC: Chas Williams <chas3@att.com>
> > CC: Bruce Richardson <bruce.richardson@intel.com>
> > CC: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
> > v5: remove extra blank line.
> > v4: fix event_eth_tx_adapter_autotest for shared build as reported by
> > travis-ci
> > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
> > v3: add missing test event_eth_tx_adapter_autotest.
> > Add link bonding mode4 test to drivers test.
> > v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1
> > ---
> > app/test/Makefile | 16 +++++-----------
> > app/test/meson.build | 36 ++++++++++++++++++++++--------------
> > app/test/process.h | 8 ++++++++
> > app/test/test.c | 2 ++
> > 4 files changed, 37 insertions(+), 25 deletions(-)
>
>
>
For the fixes related to event_eth_tx_adapter_autotest
Tested-by: Nikhil Rao <nikhil.rao@intel.com>
next prev parent reply other threads:[~2020-01-20 9:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:41 [dpdk-dev] [PATCH 1/2] app/test: fix make " Reshma Pattan
2019-10-17 9:41 ` [dpdk-dev] [PATCH 2/2] app/test: fix meson " Reshma Pattan
2019-10-17 9:51 ` Bruce Richardson
2019-10-17 9:54 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-10-17 9:48 ` [dpdk-dev] [PATCH 1/2] app/test: fix make " Bruce Richardson
2019-10-17 11:16 ` [dpdk-dev] [PATCH v2] app/test: fix " Reshma Pattan
2019-10-17 13:46 ` Bruce Richardson
2019-10-25 8:11 ` David Marchand
2019-10-25 15:40 ` Pattan, Reshma
2019-10-25 15:38 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2019-10-27 8:47 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-10-29 9:36 ` Pattan, Reshma
2019-10-31 7:58 ` David Marchand
2019-10-31 10:18 ` Pattan, Reshma
2019-12-09 13:38 ` Pattan, Reshma
2019-12-09 16:54 ` Ferruh Yigit
2019-12-09 18:00 ` Aaron Conole
2019-12-18 11:58 ` [dpdk-dev] [PATCH v4] " Reshma Pattan
2019-12-18 16:07 ` Bruce Richardson
2019-12-18 16:23 ` Pattan, Reshma
2019-12-23 6:53 ` [dpdk-dev] [PATCH v5] " Reshma Pattan
2020-01-19 21:50 ` Thomas Monjalon
2020-01-20 9:55 ` Rao, Nikhil [this message]
2020-01-20 17:36 ` Bruce Richardson
2020-02-16 18:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F668163772FA946975B9466A9DFF729EF2F0AEF@ORSMSX110.amr.corp.intel.com \
--to=nikhil.rao@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).