From: David Marchand <david.marchand@redhat.com>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Nikhil Rao <nikhil.rao@intel.com>, Chas Williams <chas3@att.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix build when ring PMD is disabled
Date: Fri, 25 Oct 2019 10:11:57 +0200 [thread overview]
Message-ID: <CAJFAV8zQrDKp6O+LRZ7PDkce-eOt365QAt7WAgjMqgTw0xahjA@mail.gmail.com> (raw)
In-Reply-To: <20191017111628.5396-1-reshma.pattan@intel.com>
On Thu, Oct 17, 2019 at 1:16 PM Reshma Pattan <reshma.pattan@intel.com> wrote:
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 2c23c6347..e221e44f7 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
[snip]
> @@ -282,7 +269,6 @@ driver_test_names = [
> 'eventdev_selftest_octeontx',
> 'eventdev_selftest_sw',
> 'link_bonding_autotest',
> - 'link_bonding_mode4_autotest',
This test was in the driver list.
> 'link_bonding_rssconf_autotest',
> 'rawdev_autotest',
> ]
> @@ -319,6 +305,20 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
> endif
Interlacing the test names, then inspecting the .c files, I noticed
that the event_eth_tx test is missing:
> if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
> test_deps += 'pmd_ring'
> + test_sources += 'test_pmd_ring_perf.c'
> + perf_test_names += 'ring_pmd_perf_autotest'
> + test_sources += 'test_pmd_ring.c'
> + fast_test_names += 'ring_pmd_autotest'
> + test_sources += 'test_event_eth_tx_adapter.c'
No associated test.
> + test_sources += 'sample_packet_forward.c'
> + test_sources += 'test_bitratestats.c'
> + fast_test_names += 'bitratestats_autotest'
> + test_sources += 'test_latencystats.c'
> + fast_test_names += 'latencystats_autotest'
> + test_sources += 'test_link_bonding_mode4.c'
Wrong list name, as I mentioned earlier.
> + fast_test_names += 'link_bonding_mode4_autotest'
> + test_sources += 'test_pdump.c'
> + fast_test_names += 'pdump_autotest'
--
David Marchand
next prev parent reply other threads:[~2019-10-25 8:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:41 [dpdk-dev] [PATCH 1/2] app/test: fix make " Reshma Pattan
2019-10-17 9:41 ` [dpdk-dev] [PATCH 2/2] app/test: fix meson " Reshma Pattan
2019-10-17 9:51 ` Bruce Richardson
2019-10-17 9:54 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-10-17 9:48 ` [dpdk-dev] [PATCH 1/2] app/test: fix make " Bruce Richardson
2019-10-17 11:16 ` [dpdk-dev] [PATCH v2] app/test: fix " Reshma Pattan
2019-10-17 13:46 ` Bruce Richardson
2019-10-25 8:11 ` David Marchand [this message]
2019-10-25 15:40 ` Pattan, Reshma
2019-10-25 15:38 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2019-10-27 8:47 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-10-29 9:36 ` Pattan, Reshma
2019-10-31 7:58 ` David Marchand
2019-10-31 10:18 ` Pattan, Reshma
2019-12-09 13:38 ` Pattan, Reshma
2019-12-09 16:54 ` Ferruh Yigit
2019-12-09 18:00 ` Aaron Conole
2019-12-18 11:58 ` [dpdk-dev] [PATCH v4] " Reshma Pattan
2019-12-18 16:07 ` Bruce Richardson
2019-12-18 16:23 ` Pattan, Reshma
2019-12-23 6:53 ` [dpdk-dev] [PATCH v5] " Reshma Pattan
2020-01-19 21:50 ` Thomas Monjalon
2020-01-20 9:55 ` Rao, Nikhil
2020-01-20 17:36 ` Bruce Richardson
2020-02-16 18:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zQrDKp6O+LRZ7PDkce-eOt365QAt7WAgjMqgTw0xahjA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).