[dpdk-dev] [PATCH] pmd: Fix pci_id match

[dpdk-dev] [PATCH] pmd: Fix pci_id match

[Asias He]

Hex numbers in /proc/ioports are lowercase. we should make it lowercase
in pci_id as well. Otherwise devices like:

   00:0a.0 Ethernet controller: Red Hat, Inc Virtio network device

would not be handled by virtio-net-pmd.

Signed-off-by: Asias He <asias.hejun@gmail.com>
---
 virtio_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtio_user.c b/virtio_user.c
index 68a7bec..04dd9ac 100644
--- a/virtio_user.c
+++ b/virtio_user.c
@@ -1385,7 +1385,7 @@ eth_virtio_dev_init(struct eth_driver *eth_drv, struct rte_eth_dev *eth_dev)
 
 	priv->pci_addr = eth_dev->pci_dev->addr;
 
-	snprintf(pci_id, sizeof(pci_id), "%04X:%02X:%02X.%d",
+	snprintf(pci_id, sizeof(pci_id), "%04x:%02x:%02x.%d",
 		 eth_dev->pci_dev->addr.domain,
 		 eth_dev->pci_dev->addr.bus,
 		 eth_dev->pci_dev->addr.devid,
-- 
1.8.5.1

Re: [dpdk-dev] [virtio-net-pmd PATCH] pmd: Fix pci_id match

[Thomas Monjalon]

Hello Asias,

04/01/2014 07:07, Asias He :
> Hex numbers in /proc/ioports are lowercase. we should make it lowercase
> in pci_id as well. Otherwise devices like:
> 
>    00:0a.0 Ethernet controller: Red Hat, Inc Virtio network device
> 
> would not be handled by virtio-net-pmd.
> 
> Signed-off-by: Asias He <asias.hejun@gmail.com>

Good catch !

I have acked and applied it with this title:
	pmd: fix PCI id match when probing

I think we should distinguish such patch for an extension from other ones.
I suggest using --subject-prefix 'virtio-net-pmd PATCH'

Thank you
-- 
Thomas