[dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD

[dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD

[Shahaf Shuler]

On mlx5 PMD Flow pattern without any specific vlan will match for vlan
packets as well.

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro nelio.laranjeiro@6wind.com
---
 doc/guides/rel_notes/release_17_08.rst | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst
index 7f1212094..bd219640c 100644
--- a/doc/guides/rel_notes/release_17_08.rst
+++ b/doc/guides/rel_notes/release_17_08.rst
@@ -111,6 +111,22 @@ Known Issues
    Also, make sure to start the actual text at the margin.
    =========================================================
 
+* **On mlx5 PMD, Flow pattern without any specific vlan will match for vlan packets as well.**
+
+  When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card.
+  Meaning, the flow rule::
+
+        flow create 0 ingress pattern eth / vlan vid is 3 / ipv4 / end ...
+
+  Will only match vlan packets with vid=3. and the flow rules::
+
+        flow create 0 ingress pattern eth / ipv4 / end ...
+
+  Or::
+
+        flow create 0 ingress pattern eth / vlan / ipv4 / end ...
+
+  Will match any ipv4 packet (VLAN included).
 
 API Changes
 -----------
-- 
2.12.0

Re: [dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD

[Adrien Mazarguil]

Hi Shahaf,

On Tue, Jun 06, 2017 at 05:20:16PM +0300, Shahaf Shuler wrote:
> On mlx5 PMD Flow pattern without any specific vlan will match for vlan
> packets as well.
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro nelio.laranjeiro@6wind.com
> ---
>  doc/guides/rel_notes/release_17_08.rst | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst
> index 7f1212094..bd219640c 100644
> --- a/doc/guides/rel_notes/release_17_08.rst
> +++ b/doc/guides/rel_notes/release_17_08.rst
> @@ -111,6 +111,22 @@ Known Issues
>     Also, make sure to start the actual text at the margin.
>     =========================================================
>  
> +* **On mlx5 PMD, Flow pattern without any specific vlan will match for vlan packets as well.**
> +
> +  When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card.
> +  Meaning, the flow rule::
> +
> +        flow create 0 ingress pattern eth / vlan vid is 3 / ipv4 / end ...
> +
> +  Will only match vlan packets with vid=3. and the flow rules::
> +
> +        flow create 0 ingress pattern eth / ipv4 / end ...
> +
> +  Or::
> +
> +        flow create 0 ingress pattern eth / vlan / ipv4 / end ...
> +
> +  Will match any ipv4 packet (VLAN included).
>  
>  API Changes
>  -----------

I do not think this should be part of the release notes as it is not a new
behavior introduced by a commit for 17.08. It has been the case since VLAN
support was added to the mlx5 rte_flow implementation back in 17.02.

Please move this info to guide/nics/mlx5.rst, the resulting documentation
commit should likely be CC'ed to stable@dpdk.org against "net/mlx5: support
VLAN flow item".

-- 
Adrien Mazarguil
6WIND

[dpdk-dev] [PATCH v2] doc: add VLAN flow limitation on mlx5 PMD

[Shahaf Shuler]

On mlx5 PMD Flow pattern without any specific vlan will match for vlan
packets as well.

Cc: stable@dpdk.org

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
on v2:
 * move the reported issue to mlx5 guide as it is present since commit
   12475fb203ad ("net/mlx5: support VLAN flow item")
---
 doc/guides/nics/mlx5.rst | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index da6dc278e..a68b7adc0 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -330,6 +330,26 @@ Supported NICs
 * Mellanox(R) ConnectX(R)-5 100G MCX556A-ECAT (2x100G)
 * Mellanox(R) ConnectX(R)-5 Ex EN 100G MCX516A-CDAT (2x100G)
 
+Known issues
+------------
+
+* **Flow pattern without any specific vlan will match for vlan packets as well.**
+
+  When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card.
+  Meaning, the flow rule::
+
+        flow create 0 ingress pattern eth / vlan vid is 3 / ipv4 / end ...
+
+  Will only match vlan packets with vid=3. and the flow rules::
+
+        flow create 0 ingress pattern eth / ipv4 / end ...
+
+  Or::
+
+        flow create 0 ingress pattern eth / vlan / ipv4 / end ...
+
+  Will match any ipv4 packet (VLAN included).
+
 Notes for testpmd
 -----------------
 
-- 
2.12.0

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: add VLAN flow limitation on mlx5 PMD

[Ferruh Yigit]

On 6/13/2017 11:20 AM, Shahaf Shuler wrote:
> On mlx5 PMD Flow pattern without any specific vlan will match for vlan
> packets as well.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.