[dpdk-dev] [PATCH 1/2] app/testpmd: fix empty list of RSS queues for flow

[dpdk-dev] [PATCH 1/2] app/testpmd: fix empty list of RSS queues for flow

[Adrien Mazarguil]

Since the commit referenced below, specifying a RSS action without any
queues (e.g. "actions rss queues end / end") does not override the default
set automatically generated by testpmd.

In short, one cannot instantiate a RSS action with 0 target queues anymore
in order to determine how PMDs react (hint: this is currently undocumented
so they may reject it, however ideally they should interpret it as a
default setting like for other fields where empty values stand for
"defaults".)

Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration")
Cc: stable@dpdk.org

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 app/test-pmd/cmdline_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 5754e7858..f4ea0a5cf 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2896,7 +2896,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token,
 	i = ctx->objdata >> 16;
 	if (!strcmp_partial("end", str, len)) {
 		ctx->objdata &= 0xffff;
-		return len;
+		goto end;
 	}
 	if (i >= ACTION_RSS_QUEUE_NUM)
 		return -1;
@@ -2916,6 +2916,7 @@ parse_vc_action_rss_queue(struct context *ctx, const struct token *token,
 	if (ctx->next_num == RTE_DIM(ctx->next))
 		return -1;
 	ctx->next[ctx->next_num++] = next;
+end:
 	if (!ctx->object)
 		return len;
 	action_rss_data = ctx->object;
-- 
2.11.0

[dpdk-dev] [PATCH 2/2] app/testpmd: fix weak RSS hash key for flow

[Adrien Mazarguil]

The default RSS hash key automatically provided by testpmd for RSS actions
specified without one is so weak that traffic can't spread properly on L4
with it (as seen with TCPv6).

It is only 30 bytes long, zero-padded to RSS_HASH_KEY_LENGTH (64 bytes),
later truncated to 40 bytes for most PMDs. The presence of padding is
really what kills balancing.

This patch provides a full 64-byte (non-zero-terminated) string to address
this issue.

Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration")
Cc: stable@dpdk.org

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 app/test-pmd/cmdline_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index f4ea0a5cf..9918d7fda 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2772,7 +2772,8 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
 			.key = action_rss_data->key,
 			.queue = action_rss_data->queue,
 		},
-		.key = "testpmd's default RSS hash key",
+		.key = "testpmd's default RSS hash key, "
+			"override it for better balancing",
 		.queue = { 0 },
 	};
 	for (i = 0; i < action_rss_data->conf.queue_num; ++i)
-- 
2.11.0

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix empty list of RSS queues for flow

[Ferruh Yigit]

On 5/3/2018 12:59 PM, Adrien Mazarguil wrote:
> Since the commit referenced below, specifying a RSS action without any
> queues (e.g. "actions rss queues end / end") does not override the default
> set automatically generated by testpmd.
> 
> In short, one cannot instantiate a RSS action with 0 target queues anymore
> in order to determine how PMDs react (hint: this is currently undocumented
> so they may reject it, however ideally they should interpret it as a
> default setting like for other fields where empty values stand for
> "defaults".)
> 
> Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix empty list of RSS queues for flow

[Ferruh Yigit]

On 5/9/2018 8:17 PM, Ferruh Yigit wrote:
> On 5/3/2018 12:59 PM, Adrien Mazarguil wrote:
>> Since the commit referenced below, specifying a RSS action without any
>> queues (e.g. "actions rss queues end / end") does not override the default
>> set automatically generated by testpmd.
>>
>> In short, one cannot instantiate a RSS action with 0 target queues anymore
>> in order to determine how PMDs react (hint: this is currently undocumented
>> so they may reject it, however ideally they should interpret it as a
>> default setting like for other fields where empty values stand for
>> "defaults".)
>>
>> Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/master, thanks.