* [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled
@ 2018-10-16 3:27 Huaibin Wang
2018-10-19 9:45 ` Huaibin Wang
0 siblings, 1 reply; 4+ messages in thread
From: Huaibin Wang @ 2018-10-16 3:27 UTC (permalink / raw)
To: dev; +Cc: Beilei Xing, Qi Zhang, huaibin Wang, Laurent Hardy
From: huaibin Wang <huaibin.wang@6wind.com>
Promisc should not be disabled if the all multicast mode is enabled.
Patch keeps the promiscuous on if all multicast mode is on, this
behavior is also consistant with the implementation done on ixgbe
pmd.
Signed-off-by: huaibin Wang <huaibin.wang@6wind.com>
Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
---
Cc: Beilei Xing <beilei.xing@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/i40e/i40e_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index f7a685c8c..6c503debc 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev)
if (status != I40E_SUCCESS)
PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");
+ /* must remain in all_multicast mode */
+ if (dev->data->all_multicast == 1)
+ return;
+
status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
false, NULL);
if (status != I40E_SUCCESS)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled
2018-10-16 3:27 [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled Huaibin Wang
@ 2018-10-19 9:45 ` Huaibin Wang
2018-10-19 18:16 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Huaibin Wang @ 2018-10-19 9:45 UTC (permalink / raw)
To: dev; +Cc: Beilei Xing, Qi Zhang, huaibin Wang, Laurent Hardy
From: huaibin Wang <huaibin.wang@6wind.com>
Promisc should not be disabled if the all multicast mode is enabled.
Patch keeps the promiscuous on if all multicast mode is on, this
behavior is also consistent with the implementation done on ixgbe
pmd.
Signed-off-by: huaibin Wang <huaibin.wang@6wind.com>
Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
---
Cc: Beilei Xing <beilei.xing@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/i40e/i40e_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index f7a685c8c..6c503debc 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev)
if (status != I40E_SUCCESS)
PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");
+ /* must remain in all_multicast mode */
+ if (dev->data->all_multicast == 1)
+ return;
+
status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
false, NULL);
if (status != I40E_SUCCESS)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled
2018-10-19 9:45 ` Huaibin Wang
@ 2018-10-19 18:16 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2018-10-19 18:16 UTC (permalink / raw)
To: Huaibin Wang, dev; +Cc: Xing, Beilei, Laurent Hardy
> -----Original Message-----
> From: Huaibin Wang [mailto:huaibin.wang@6wind.com]
> Sent: Friday, October 19, 2018 2:45 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> huaibin Wang <huaibin.wang@6wind.com>; Laurent Hardy
> <laurent.hardy@6wind.com>
> Subject: [PATCH] net/i40e: keep promisc on if allmulticast is enabled
>
> From: huaibin Wang <huaibin.wang@6wind.com>
>
> Promisc should not be disabled if the all multicast mode is enabled.
> Patch keeps the promiscuous on if all multicast mode is on, this behavior is
> also consistent with the implementation done on ixgbe pmd.
>
> Signed-off-by: huaibin Wang <huaibin.wang@6wind.com>
> Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Cc: stable@dpdk.org is added.
Thanks
Qi
> ---
> Cc: Beilei Xing <beilei.xing@intel.com>
> Cc: Qi Zhang <qi.z.zhang@intel.com>
>
> drivers/net/i40e/i40e_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index f7a685c8c..6c503debc 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct
> rte_eth_dev *dev)
> if (status != I40E_SUCCESS)
> PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");
>
> + /* must remain in all_multicast mode */
> + if (dev->data->all_multicast == 1)
> + return;
> +
> status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
> false, NULL);
> if (status != I40E_SUCCESS)
> --
> 2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled
[not found] <20181016031405.28638-1-huaibin.wang@6wind.com>
@ 2018-10-19 9:43 ` Huaibin Wang
0 siblings, 0 replies; 4+ messages in thread
From: Huaibin Wang @ 2018-10-19 9:43 UTC (permalink / raw)
To: dev; +Cc: Beilei Xing, Qi Zhang, huaibin Wang, Laurent Hardy
From: huaibin Wang <huaibin.wang@6wind.com>
Promisc should not be disabled if the all multicast mode is enabled.
Patch keeps the promiscuous on if all multicast mode is on, this
behavior is also consistent with the implementation done on ixgbe
pmd.
Signed-off-by: huaibin Wang <huaibin.wang@6wind.com>
Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
---
Cc: Beilei Xing <beilei.xing@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/i40e/i40e_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index f7a685c8c..6c503debc 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev)
if (status != I40E_SUCCESS)
PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");
+ /* must remain in all_multicast mode */
+ if (dev->data->all_multicast == 1)
+ return;
+
status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,
false, NULL);
if (status != I40E_SUCCESS)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-19 18:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 3:27 [dpdk-dev] [PATCH] net/i40e: keep promisc on if allmulticast is enabled Huaibin Wang
2018-10-19 9:45 ` Huaibin Wang
2018-10-19 18:16 ` Zhang, Qi Z
[not found] <20181016031405.28638-1-huaibin.wang@6wind.com>
2018-10-19 9:43 ` Huaibin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).