DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: dev <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix device removal handler for multiport device
Date: Fri, 10 May 2019 21:24:54 +0000	[thread overview]
Message-ID: <19FAA938-F942-47DD-8A26-A5A56E828079@mellanox.com> (raw)
Message-ID: <20190510212454._bf_MLvHjoBfxM135oZiU3-riTLjmiLQGikeqGRDrtg@z> (raw)
In-Reply-To: <1557498982-27734-1-git-send-email-viacheslavo@mellanox.com>


> On May 10, 2019, at 7:36 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
> 
> IBV_EVENT_DEVICE_FATAL event is generated by the driver once for
> the entire multiport Infiniband device, not for each existing ports.
> The port index is zero and it causes dropping the device removal
> event. We should invoke the removal event processing routine
> for each port we have installed handler for.
> 
> Fixes: 028b2a28c3cb ("net/mlx5: update event handler for multiport IB devices")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 43 +++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 80ee98f..3962d41 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -1116,6 +1116,35 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
> }
> 
> /**
> + * Handle asynchronous removal event for entire multiport device.
> + *
> + * @param sh
> + *   Infiniband device shared context.
> + */
> +static void
> +mlx5_dev_interrupt_device_fatal(struct mlx5_ibv_shared *sh)
> +{
> +	uint32_t i;
> +
> +	for (i = 0; i < sh->max_port; ++i) {
> +		struct rte_eth_dev *dev;
> +
> +		if (sh->port[i].ih_port_id >= RTE_MAX_ETHPORTS) {
> +			/*
> +			 * Or not existing port either no
> +			 * handler installed for this port.
> +			 */
> +			continue;
> +		}
> +		dev = &rte_eth_devices[sh->port[i].ih_port_id];
> +		assert(dev);
> +		if (dev->data->dev_conf.intr_conf.rmv)
> +			_rte_eth_dev_callback_process
> +				(dev, RTE_ETH_EVENT_INTR_RMV, NULL);
> +	}
> +}
> +
> +/**
>  * Handle shared asynchronous events the NIC (removal event
>  * and link status change). Supports multiport IB device.
>  *
> @@ -1137,6 +1166,16 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
> 			break;
> 		/* Retrieve and check IB port index. */
> 		tmp = (uint32_t)event.element.port_num;
> +		if (!tmp && event.event_type == IBV_EVENT_DEVICE_FATAL) {
> +			/*
> +			 * The DEVICE_FATAL event is called once for
> +			 * entire device without port specifying.
> +			 * We should notify all existing ports.
> +			 */
> +			mlx5_glue->ack_async_event(&event);
> +			mlx5_dev_interrupt_device_fatal(sh);
> +			continue;
> +		}

Then, you should clear the previous handle below, right? I mean this if-clause.

		if (event.event_type == IBV_EVENT_DEVICE_FATAL &&

> 		assert(tmp && (tmp <= sh->max_port));
> 		if (!tmp ||
> 		    tmp > sh->max_port ||
> @@ -1146,12 +1185,14 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
> 			 * installed for this port.
> 			 */
> 			mlx5_glue->ack_async_event(&event);
> +			DRV_LOG(DEBUG,
> +				"port %u event type %d on not handled",

Needs to fix the sentence. Be more specific. For example,
				port %u cannot handle an event (type %d) due to invalid IB port index

One more below. That should be something like 
				port %u cannot handle an unknown event (type %d)

Thanks,
Yongseok

> +				tmp, event.event_type);
> 			continue;
> 		}
> 		/* Retrieve ethernet device descriptor. */
> 		tmp = sh->port[tmp - 1].ih_port_id;
> 		dev = &rte_eth_devices[tmp];
> -		tmp = 0;
> 		assert(dev);
> 		if ((event.event_type == IBV_EVENT_PORT_ACTIVE ||
> 		     event.event_type == IBV_EVENT_PORT_ERR) &&
> -- 
> 1.8.3.1
> 


  parent reply	other threads:[~2019-05-10 21:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 14:36 Viacheslav Ovsiienko
2019-05-10 14:36 ` Viacheslav Ovsiienko
2019-05-10 21:24 ` Yongseok Koh [this message]
2019-05-10 21:24   ` Yongseok Koh
2019-05-12  8:32 ` [dpdk-dev] [PATCH v2] " Viacheslav Ovsiienko
2019-05-12  8:32   ` Viacheslav Ovsiienko
2019-05-12 12:15   ` Shahaf Shuler
2019-05-12 12:15     ` Shahaf Shuler
2019-05-12 17:17     ` Shahaf Shuler
2019-05-12 17:17       ` Shahaf Shuler
2019-05-13 14:30       ` Thomas Monjalon
2019-05-13 14:30         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19FAA938-F942-47DD-8A26-A5A56E828079@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).