From: guohongzhi <guohongzhi1@huawei.com>
To: <dev@dpdk.org>
Cc: <stable@dpdk.org>, <olivier.matz@6wind.com>,
<mb@smartsharesystems.com>, <konstantin.ananyev@intel.com>,
<jiayu.hu@intel.com>, <ferruh.yigit@intel.com>,
<nicolas.chautru@intel.com>, <cristian.dumitrescu@intel.com>,
<zhoujingbin@huawei.com>, <chenchanghu@huawei.com>,
<jerry.lilijun@huawei.com>, <haifeng.lin@huawei.com>,
<guohongzhi1@huawei.com>
Subject: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
Date: Tue, 26 May 2020 18:08:05 +0800 [thread overview]
Message-ID: <20200526100805.24896-1-guohongzhi1@huawei.com> (raw)
From: Hongzhi Guo <guohongzhi1@huawei.com>
0xffff is invalid for IPv4 checksum(RFC1624)
Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org
Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
---
lib/librte_net/rte_ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
{
uint16_t cksum;
cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
- return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+ return (uint16_t)~cksum;
}
/**
--
2.21.0.windows.1
next reply other threads:[~2020-05-26 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 10:08 guohongzhi [this message]
2020-06-24 11:53 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2020-05-26 9:16 guohongzhi
2020-05-26 9:31 ` Morten Brørup
2020-05-14 1:27 guohongzhi
2020-05-24 15:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526100805.24896-1-guohongzhi1@huawei.com \
--to=guohongzhi1@huawei.com \
--cc=chenchanghu@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).