DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: SteveX Yang <stevex.yang@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, beilei.xing@intel.com,
	qiming.yang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib
Date: Thu, 10 Sep 2020 10:23:41 +0100	[thread overview]
Message-ID: <20200910092341.GD1789@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200910022018.8955-1-stevex.yang@intel.com>

On Thu, Sep 10, 2020 at 02:20:18AM +0000, SteveX Yang wrote:
> meson build cannot find the header rte_latencystats.h when build DPDK
> first time or never installed DPDK lib after build via meson/ninja.
> 
> Because the corresponding header directory isn't included after enabled
> RTE_LIBRTE_LATENCY_STATS flag.
> 
> Add the header file location and link library to meson.build of test-pmd
> 
> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> ---

As before, I think we have a mismatch in old vs new macro names which is
why this wasn't caught before. Therefore I suggest we just change testpmd
to use the new macro to keep things standardized. [Other alternatives if we
want to keep compatibility are to rename the latencystats directory to have
an underscore in it, or to override the name (which I'd rather not go for)]

>  app/test-pmd/meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
> index db0ff02eb..6ee7af750 100644
> --- a/app/test-pmd/meson.build
> +++ b/app/test-pmd/meson.build
> @@ -9,6 +9,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
>  	cflags += '-I' + meson.source_root() + '/drivers/net/bonding'
>  endif
>  
> +if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS')
> +	cflags += '-I' + meson.source_root() + '/lib/librte_latencystats'
> +endif
> +

Rather than working with long cflags, just add latencystats as a dependency
of testpmd.

>  sources = files('5tswap.c',
>  	'cmdline.c',
>  	'cmdline_flow.c',
> -- 
> 2.17.1
> 

  reply	other threads:[~2020-09-10  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  2:20 SteveX Yang
2020-09-10  9:23 ` Bruce Richardson [this message]
     [not found]   ` <DM6PR11MB4362CE65DBD5BA111A43A0FAF9230@DM6PR11MB4362.namprd11.prod.outlook.com>
2020-09-14  8:34     ` Bruce Richardson
2020-09-15  2:08 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-30 16:25   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910092341.GD1789@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    --cc=stevex.yang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).