From: Maxime Leroy <maxime.leroy@6wind.com> To: Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Olivier Matz <olivier.matz@6wind.com> Cc: dev@dpdk.org, Didier Pallard <didier.pallard@6wind.com> Subject: [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value Date: Tue, 17 Nov 2020 12:26:47 +0100 Message-ID: <20201117112648.29725-3-maxime.leroy@6wind.com> (raw) In-Reply-To: <20201117112648.29725-1-maxime.leroy@6wind.com> From: Didier Pallard <didier.pallard@6wind.com> Three bugs in rx_queue_count function: - One entry may contain several segments, so 'used' must be multiplied by number of segments per entry to properly reflect the queue usage. - The number of cqes is equals to (1U << rxq->elts_n) - 1 in SPRQ mode. The range returned by rx_queue_count should be the number of entries used in queue, so it ranges from 0 to max number of entries in queue, not this number minus one. - For MPRQ mode, we need to take into account of the number of strd. Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") Signed-off-by: Didier Pallard <didier.pallard@6wind.com> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com> --- drivers/net/mlx5/mlx5_rxtx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 2733dcd3..2ecf901f 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -463,6 +463,9 @@ rx_queue_count(struct mlx5_rxq_data *rxq) struct rxq_zip *zip = &rxq->zip; volatile struct mlx5_cqe *cqe; const unsigned int cqe_n = (1 << rxq->cqe_n); + const unsigned int sges_n = (1 << rxq->sges_n); + const unsigned int elts_n = (1 << rxq->elts_n); + const unsigned int strd_n = (1 << rxq->strd_num_n); const unsigned int cqe_cnt = cqe_n - 1; unsigned int cq_ci, used; @@ -488,7 +491,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq) used += n; cqe = &(*rxq->cqes)[cq_ci & cqe_cnt]; } - used = RTE_MIN(used, cqe_n); + used = RTE_MIN(used * sges_n, elts_n * strd_n); return used; } -- 2.27.0
next prev parent reply other threads:[~2020-11-17 11:27 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-17 11:26 [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx queue count calculation Maxime Leroy 2020-11-17 11:26 ` [dpdk-dev] [PATCH v4 1/2] net/mlx5: fix Rx " Maxime Leroy 2020-11-17 12:06 ` Slava Ovsiienko 2020-11-17 11:26 ` Maxime Leroy [this message] 2020-11-17 12:05 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value Slava Ovsiienko 2020-11-17 13:48 ` [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx queue count calculation Raslan Darawsheh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201117112648.29725-3-maxime.leroy@6wind.com \ --to=maxime.leroy@6wind.com \ --cc=dev@dpdk.org \ --cc=didier.pallard@6wind.com \ --cc=matan@nvidia.com \ --cc=olivier.matz@6wind.com \ --cc=shahafs@nvidia.com \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git