From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Maxime Leroy <maxime.leroy@6wind.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-N?lio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/mlx5: fix Rx queue count calculation
Date: Tue, 17 Nov 2020 12:06:10 +0000 [thread overview]
Message-ID: <MWHPR12MB15011F671D05F9687D7366B2DFE20@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201117112648.29725-2-maxime.leroy@6wind.com>
> -----Original Message-----
> From: Maxime Leroy <maxime.leroy@6wind.com>
> Sent: Tuesday, November 17, 2020 13:27
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-N?lio Laranjeiro
> <nelio.laranjeiro@6wind.com>
> Subject: [PATCH v4 1/2] net/mlx5: fix Rx queue count calculation
>
> The commit d2d57605522d ("net/mlx5: fix Rx queue count calculation") is
> incorrect because the count calculation is wrong for the next cqe:
>
> Example:
>
> Compressed Set of packets 1 | Compressed Set of packets 2
> C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0
>
> There are 2 compressed set of packets in the first queue. For the first set, n is
> computed correctly.
>
> But for the second, n is not computed properly. Because the zip context is for
> the first set. The second set is not yet decompressed, so there are no context.
>
> To fix the issue, we should only use the zip context for the first CQEs series.
>
> Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation")
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2020-11-17 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 11:26 [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx " Maxime Leroy
2020-11-17 11:26 ` [dpdk-dev] [PATCH v4 1/2] net/mlx5: fix Rx " Maxime Leroy
2020-11-17 12:06 ` Slava Ovsiienko [this message]
2020-11-17 11:26 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value Maxime Leroy
2020-11-17 12:05 ` Slava Ovsiienko
2020-11-17 13:48 ` [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx queue count calculation Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB15011F671D05F9687D7366B2DFE20@MWHPR12MB1501.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=maxime.leroy@6wind.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).