DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	dev@dpdk.org, david.marchand@redhat.com,
	bruce.richardson@intel.com, stephen@networkplumber.org,
	drc@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro
Date: Thu, 25 Mar 2021 11:50:26 -0700	[thread overview]
Message-ID: <20210325185026.GA11101@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <6471682.gLmPldMPvt@thomas>

On Thu, Mar 25, 2021 at 09:00:54AM +0100, Thomas Monjalon wrote:
> 25/03/2021 01:09, Tyler Retzlaff:
> > On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote:
> > > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff:
> > > 
> > > Can't speak for Seastar and Click, but we never hit this particular issue.
> > > What is the minimal complete example to reproduce?
> > 
> > interesting, i did a bit more digging and it is clear why. i'm consuming
> > headers and crt that have been enhanced to enforce c++ standards
> > compliance. after dumping the preprocessed output i suspect this cannot
> > be reproduced with the publicly available headers it seems i'm the only
> > "beneficiary" heh.
> > 
> > so the minimal example is really just to #include <list> after including
> > say rte_windows.h but it won't reproduce for public users of the sdk.
> > 
> > if there is a great deal of concern with respect to compatibility i
> > guess as the single consumer who has this problem i can just #undef asm
> > since we don't use inline asm anyway.
> > 
> > thoughts?
> 
> No please don't do this.
> There is an issue in DPDK which must be fixed.
> It seems your patch is correct, I am waiting for confirmation of others.
> 

thanks, i'm glad for the desire to make the proper fix. we'll wait for
others to comment.


  reply	other threads:[~2021-03-25 18:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  4:26 Tyler Retzlaff
2021-03-24  8:30 ` Thomas Monjalon
2021-03-24 16:45   ` Tyler Retzlaff
2021-03-24 17:04     ` Thomas Monjalon
2021-03-24 17:28       ` Tyler Retzlaff
2021-03-24 17:52         ` Thomas Monjalon
2021-03-24 19:52           ` Stephen Hemminger
2021-03-24 21:58             ` Tyler Retzlaff
2021-03-24 21:55           ` Tyler Retzlaff
2021-03-24 22:41             ` Dmitry Kozlyuk
2021-03-25  0:09               ` Tyler Retzlaff
2021-03-25  8:00                 ` Thomas Monjalon
2021-03-25 18:50                   ` Tyler Retzlaff [this message]
2021-04-13 13:10                     ` Thomas Monjalon
2021-04-13 13:35 ` Thomas Monjalon
2021-04-17  1:16   ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210325185026.GA11101@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=drc@linux.vnet.ibm.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).