Re: [dpdk-dev] [RFC v3 4/6] eal: add a helper for reading string from sysfs

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue,  1 Jun 2021 11:06:42 +0800
Chenbo Xia <chenbo.xia@intel.com> wrote:

> +int
> +rte_eal_parse_sysfs_str(const char *filename, char *buf, unsigned long sz)
> +{
> +	FILE *f;
> +
> +	f = fopen(filename, "r");
> +	if (f == NULL) {
> +		RTE_LOG(ERR, EAL, "%s(): cannot open sysfs file %s\n",
> +			__func__, filename);
> +		return -1;
> +	}
> +
> +	if (fgets(buf, sz, f) == NULL) {
> +		RTE_LOG(ERR, EAL, "%s(): cannot read sysfs file %s\n",
> +			__func__, filename);
> +		fclose(f);
> +		return -1;
> +	}
> +
> +	fclose(f);
> +	return 0;
> +}

It would be helpful if function removed trailing newline.
	strchrnul(buf, '\n') = '\0';